Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: merge admin and standard clients, merge sync and async integration tests, use test fixtures for setup and teardown, add missing docstrings. vec-466 vec-344 vec-388 vec-481 vec-373 #69

Merged
merged 21 commits into from
Jan 8, 2025

Conversation

dwelch-spike
Copy link
Contributor

@dwelch-spike dwelch-spike commented Dec 20, 2024

  • Add missing docstrings to HNSWParams
  • propogate index and record fixtures through async tests
  • Remove deprecated wait_for_index_completion from tests
  • Merges the sync and async test suites by parameterizing the sync and async clients (this is responsible for most of the removed code)
  • Removes the service config tests, these will be replacaed soon by unit tests. I already have a branch started for this at vec-484.
  • Speeds up the tests by splitting async and sync into separate, parallel jobs, configuring test indexes to index records more quickly, and removing the async test suite. Test runtime went from around 30minutes to around 4 minutes.

@dwelch-spike dwelch-spike self-assigned this Dec 20, 2024
@dwelch-spike dwelch-spike marked this pull request as draft December 20, 2024 18:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 69.73684% with 92 lines in your changes missing coverage. Please review.

Project coverage is 69.48%. Comparing base (b162a6e) to head (813d4b5).

Files with missing lines Patch % Lines
src/aerospike_vector_search/aio/client.py 71.25% 46 Missing ⚠️
src/aerospike_vector_search/client.py 68.05% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   71.83%   69.48%   -2.35%     
==========================================
  Files          25       23       -2     
  Lines        2393     2353      -40     
==========================================
- Hits         1719     1635      -84     
- Misses        674      718      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwelch-spike dwelch-spike changed the title refactor: propogate index and record fixtures through async tests refactor: merge sync and async integration tests, use test fictures for setup and teardown, addd missing docstrings. Dec 30, 2024
@dwelch-spike dwelch-spike marked this pull request as ready for review December 30, 2024 23:47
Copy link
Contributor

@DomPeliniAerospike DomPeliniAerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dwelch-spike dwelch-spike changed the title refactor: merge sync and async integration tests, use test fictures for setup and teardown, addd missing docstrings. refactor: merge sync and async integration tests, use test fixtures for setup and teardown, addd missing docstrings. Jan 3, 2025
@dwelch-spike dwelch-spike changed the title refactor: merge sync and async integration tests, use test fixtures for setup and teardown, addd missing docstrings. refactor: merge sync and async integration tests, use test fixtures for setup and teardown, add missing docstrings. Jan 8, 2025
@dwelch-spike dwelch-spike changed the title refactor: merge sync and async integration tests, use test fixtures for setup and teardown, add missing docstrings. refactor!: merge admin and standard clients, merge sync and async integration tests, use test fixtures for setup and teardown, add missing docstrings. vec-466 vec-344 vec-388 vec-481 vec-373 Jan 8, 2025
@dwelch-spike dwelch-spike merged commit e6aa2ae into main Jan 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants