-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: merge admin and standard clients, merge sync and async integration tests, use test fixtures for setup and teardown, add missing docstrings. vec-466 vec-344 vec-388 vec-481 vec-373 #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dwelch-spike
commented
Dec 20, 2024
•
edited
Loading
edited
- Add missing docstrings to HNSWParams
- propogate index and record fixtures through async tests
- Remove deprecated wait_for_index_completion from tests
- Merges the sync and async test suites by parameterizing the sync and async clients (this is responsible for most of the removed code)
- Removes the service config tests, these will be replacaed soon by unit tests. I already have a branch started for this at vec-484.
- Speeds up the tests by splitting async and sync into separate, parallel jobs, configuring test indexes to index records more quickly, and removing the async test suite. Test runtime went from around 30minutes to around 4 minutes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 71.83% 69.48% -2.35%
==========================================
Files 25 23 -2
Lines 2393 2353 -40
==========================================
- Hits 1719 1635 -84
- Misses 674 718 +44 ☔ View full report in Codecov by Sentry. |
dwelch-spike
changed the title
refactor: propogate index and record fixtures through async tests
refactor: merge sync and async integration tests, use test fictures for setup and teardown, addd missing docstrings.
Dec 30, 2024
DomPeliniAerospike
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dwelch-spike
changed the title
refactor: merge sync and async integration tests, use test fictures for setup and teardown, addd missing docstrings.
refactor: merge sync and async integration tests, use test fixtures for setup and teardown, addd missing docstrings.
Jan 3, 2025
dwelch-spike
changed the title
refactor: merge sync and async integration tests, use test fixtures for setup and teardown, addd missing docstrings.
refactor: merge sync and async integration tests, use test fixtures for setup and teardown, add missing docstrings.
Jan 8, 2025
dwelch-spike
changed the title
refactor: merge sync and async integration tests, use test fixtures for setup and teardown, add missing docstrings.
refactor!: merge admin and standard clients, merge sync and async integration tests, use test fixtures for setup and teardown, add missing docstrings. vec-466 vec-344 vec-388 vec-481 vec-373
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.