-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEC-399: Add typehints #63
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 71.65% 71.64% -0.02%
==========================================
Files 25 25
Lines 2353 2352 -1
==========================================
- Hits 1686 1685 -1
Misses 667 667 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visually looks good but I wasn't able to get python type hints in my editor so I will leave it to someone else to approve.
Also I see there are some broken tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments to double check things. I also pulled this branch into my IDE and went through some files with PyLance to see if it highlights any type hint issues. It looks much better but still has some. I included a photo of an example. @rahul-aerospike can you install the pylance extension in vscode and take a look? If you can't get it to work let me know and I can make the changes on my side.
Co-authored-by: dwelch-spike <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, test failures look timing based.
No description provided.