Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEC-399: Add typehints #63

Merged
merged 11 commits into from
Nov 14, 2024
Merged

VEC-399: Add typehints #63

merged 11 commits into from
Nov 14, 2024

Conversation

rahul-aerospike
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 90.74074% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (0f7cfc5) to head (a104f16).

Files with missing lines Patch % Lines
src/aerospike_vector_search/shared/conversions.py 66.66% 7 Missing ⚠️
src/aerospike_vector_search/aio/client.py 50.00% 1 Missing ⚠️
...ike_vector_search/aio/internal/channel_provider.py 66.66% 1 Missing ⚠️
src/aerospike_vector_search/client.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   71.65%   71.64%   -0.02%     
==========================================
  Files          25       25              
  Lines        2353     2352       -1     
==========================================
- Hits         1686     1685       -1     
  Misses        667      667              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahul-aerospike rahul-aerospike changed the title Test intermediate changes in CI VEC-399: Add typehints Nov 5, 2024
Copy link

@arrowplum arrowplum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visually looks good but I wasn't able to get python type hints in my editor so I will leave it to someone else to approve.

@arrowplum
Copy link

Also I see there are some broken tests

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments to double check things. I also pulled this branch into my IDE and went through some files with PyLance to see if it highlights any type hint issues. It looks much better but still has some. I included a photo of an example. @rahul-aerospike can you install the pylance extension in vscode and take a look? If you can't get it to work let me know and I can make the changes on my side.

image

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures look timing based.

@rahul-aerospike rahul-aerospike merged commit c99344f into main Nov 14, 2024
11 of 14 checks passed
@rahul-aerospike rahul-aerospike deleted the vec-399 branch November 14, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants