Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable metrics collection on docker compose example vec-409 #73

Closed
wants to merge 9 commits into from

Conversation

dwelch-spike
Copy link
Contributor

No description provided.

@dwelch-spike dwelch-spike self-assigned this Nov 20, 2024
Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we need a way to cover all the other docker-compose files. Specifically prism, quote search, and 6.4.

@dwelch-spike dwelch-spike requested a review from hev December 5, 2024 18:40
@dwelch-spike
Copy link
Contributor Author

@hev I added metrics collection to the other compose files and centralized its config in the .internal directory. I tested these changes locally, each worked and metrics were visible on prometheus.

Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt test all the variations but approving.

@hev hev self-requested a review December 9, 2024 22:57
Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to do some kind of disclosure here. Something like the following.

This repo contains examples that collects basic usage data about the product including network information. You can opt out of this by disabling Prometheus in any of the install instructions.

@dwelch-spike dwelch-spike requested a review from hev December 10, 2024 00:01
@dwelch-spike
Copy link
Contributor Author

I think we need to do some kind of disclosure here. Something like the following.

This repo contains examples that collects basic usage data about the product including network information. You can opt out of this by disabling Prometheus in any of the install instructions.

I added disclosures to the readme files

Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Looks good.

@dwelch-spike
Copy link
Contributor Author

Tested locally after Joe reverted the service rename. docker, quote search, and prism search compose files all worked for me.

@hev hev self-requested a review December 10, 2024 03:45
@dwelch-spike
Copy link
Contributor Author

I'm going to do a little more testing tomorrow to make sure metrics are showing up in our monitoring stack still, then will merge this

Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on merging this. Waiting on feedback for leadership.

@hev
Copy link
Contributor

hev commented Dec 11, 2024

No longer moving forward on this.

@hev hev closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants