feat: vec-270 support separate index a nd vector data namespaces #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd vector namespaces
…ESPACE and AVS_SET to avoid a breaking change
hev
approved these changes
Aug 2, 2024
|
Leaving this branch for now because Adam sent it to a customer to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the AVS_INDEX_NAMESPACE and AVS_INDEX_SET configs to the quote, image, and (attempted kuberenetes) examples, it does not change the basic search example at all. BY default, the quote and image search examples will store all data in the test namespace, however, the docker compose will store data and index separately. I tested these locally but have not tested the Kubernetes example, I think @davi17g should have a look there.
NOTE: I changed the Aerospike config in the docker example to use separate namespaces for data and index which enforces best practices but does make it harder to use with the example, @hev let me know if you want this reverted or documented somehow.