Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3161] Type stubs: add TypedDict class for the client config dictionary #690

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Nov 6, 2024

  • Manually verified that we can import our subclasses of typeddict and use them with the Python client

todo: add test using mypy to check that this doesn't break applications with static checking

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (ca2f4be) to head (120f84e).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #690   +/-   ##
=======================================
  Coverage   80.89%   80.89%           
=======================================
  Files         102      102           
  Lines       15186    15186           
=======================================
  Hits        12285    12285           
  Misses       2901     2901           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants