[CLIENT-2645] Add ttl option for default write policies in client config #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## stage #536 +/- ##
==========================================
- Coverage 81.06% 81.05% -0.01%
==========================================
Files 98 98
Lines 14828 14833 +5
==========================================
+ Hits 12020 12023 +3
- Misses 2808 2810 +2
☔ View full report in Codecov by Sentry. |
yuvalspinzi
previously approved these changes
Nov 8, 2023
dwelch-spike
requested changes
Nov 8, 2023
| @@ -442,6 +443,7 @@ class Query: | |||
| def where(self, predicate: tuple, ctx: list = ...) -> None: ... | |||
|
|
|||
| class Scan: | |||
| ttl: int | |||
There was a problem hiding this comment.
Do queries need this too?
There was a problem hiding this comment.
The type stubs already have aerospike.Query.ttl
Co-authored-by: dwelch-spike <[email protected]>
|
I fixed an extra doc error. Setting |
juliannguyen4
force-pushed
the
CLIENT-2645-client-conf-ttl
branch
from
dee00ae to
d6dd722
Compare
dwelch-spike
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build wheels all passes: https://github.com/aerospike/aerospike-client-python/actions/runs/6792350139
Valgrind
This branch: https://github.com/aerospike/aerospike-client-python/actions/runs/6792351521/job/18465486663
Stage branch: https://github.com/aerospike/aerospike-client-python/actions/runs/6793233371/job/18467761697
No extra memory errors or leaks caused by these changes
C client API changes: aerospike/aerospike-client-c@600d2d2
Documentation:
aerospike.Scan.ttlproperly for some reason...Extra changes:
batch_operate()now takes in an optional ttl parameter instead of taking ttl through a batch policy. Documentation changesttloption. Documentationttloption toaerospike.Scanclass. Documentation