-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-2604] Add support for persisting map indexes #534
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## stage #534 +/- ##
==========================================
+ Coverage 81.29% 81.33% +0.04%
==========================================
Files 98 98
Lines 14766 14783 +17
==========================================
+ Hits 12004 12024 +20
+ Misses 2762 2759 -3
☔ View full report in Codecov by Sentry. |
b5cea99
to
67819ad
Compare
1280a80
to
d37c0bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
Build wheels passes: https://github.com/aerospike/aerospike-client-python/actions/runs/6567382147
Valgrind
No memory errors or leaks introduced by this change: https://github.com/aerospike/aerospike-client-python/actions/runs/6567384487/job/17839974892
Extra changes:
Documentation:
map policy new option: https://aerospike-python-client--534.org.readthedocs.build/en/534/client.html#map-policies
map_create operation: https://aerospike-python-client--534.org.readthedocs.build/en/534/aerospike_helpers.operations.html#aerospike_helpers.operations.map_operations.map_create