Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2570] Add RecordSize() expression #519

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 22, 2023

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (76bb965) 81.31% compared to head (85994f2) 81.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #519      +/-   ##
==========================================
+ Coverage   81.31%   81.32%   +0.01%     
==========================================
  Files          98       98              
  Lines       14757    14766       +9     
==========================================
+ Hits        11999    12008       +9     
  Misses       2758     2758              
Files Coverage Δ
aerospike_helpers/expressions/base.py 99.52% <100.00%> (+0.01%) ⬆️
aerospike_helpers/expressions/resources.py 97.26% <100.00%> (+0.01%) ⬆️
src/main/convert_expressions.c 88.39% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 added the new-server-features Test against the latest server release candidate label Oct 10, 2023
@juliannguyen4 juliannguyen4 marked this pull request as ready for review October 12, 2023 21:29
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliannguyen4 juliannguyen4 merged commit 4d653b2 into stage Oct 17, 2023
@juliannguyen4 juliannguyen4 deleted the CLIENT-2570-exp-record-size branch October 17, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-server-features Test against the latest server release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants