Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2547] CI/CD: Make bumping version in build wheels workflow optional #506

Merged
merged 9 commits into from
Sep 8, 2023

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 7, 2023

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a64b83e) 81.30% compared to head (63aecdf) 81.30%.
Report is 1 commits behind head on stage.

❗ Current head 63aecdf differs from pull request most recent head e40a6b1. Consider uploading reports for the commit e40a6b1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #506   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files          98       98           
  Lines       14808    14808           
=======================================
  Hits        12039    12039           
  Misses       2769     2769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review September 8, 2023 19:43
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks okay. not super comfortable with being able to opt out of bumps, so please make sure people use this with caution...

Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit 5987421 into stage Sep 8, 2023
@juliannguyen4 juliannguyen4 deleted the CLIENT-2547-bump-optional branch September 8, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants