-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-2196] Add missing batch policies to client config #495
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## stage #495 +/- ##
==========================================
+ Coverage 81.27% 81.33% +0.05%
==========================================
Files 98 98
Lines 14645 14717 +72
==========================================
+ Hits 11903 11970 +67
- Misses 2742 2747 +5
☔ View full report in Codecov by Sentry. |
// For batch write, batch apply, and batch remove policies: | ||
// Don't set expressions field since it depends on the client's | ||
// serialization policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should note that the client level policies do not accept expressions in the docs at https://aerospike-python-client.readthedocs.io/en/latest/aerospike.html#client-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a docs preview at the top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM but I think you should note that client level policies don't accept expressions in the docs. See my other comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docs: https://aerospike-python-client--495.org.readthedocs.build/en/495/aerospike.html#client-configuration
Build wheels: https://github.com/aerospike/aerospike-client-python/actions/runs/5969042908
Valgrind
Stage branch: https://github.com/aerospike/aerospike-client-python/actions/runs/5969045150/job/16194118766
This branch: https://github.com/aerospike/aerospike-client-python/actions/runs/5969044645
AerospikeClient_New:
Stage:
4 raise_exception
4 add_host
This branch:
5 raise_exception
4 add_host
Extra raise_exception leak caused by negative tests being added in this PR.
AerospikeClient_Type_Init (from same stack as AerospikeClient_New leaks)
AerospikeQuery_Get_Partitions_status doesn't seem related to this PR