Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-1843] Lint test code #301

Merged
merged 25 commits into from
Nov 2, 2022

Conversation

juliannguyen4
Copy link
Collaborator

No description provided.

@juliannguyen4
Copy link
Collaborator Author

Command used: black -l 120 test/

@juliannguyen4
Copy link
Collaborator Author

Additional change: tests will fail if aerospike isn't installed instead of skipping

@juliannguyen4 juliannguyen4 marked this pull request as ready for review October 20, 2022 18:53
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Discussed removal of weird import aerospike code with Julian - I agree it should be removed.

@juliannguyen4 juliannguyen4 merged commit ac3e27b into aerospike:stage Nov 2, 2022
@juliannguyen4 juliannguyen4 deleted the CLIENT-1843-testcode branch November 2, 2022 17:13
juliannguyen4 added a commit to juliannguyen4/aerospike-client-python that referenced this pull request Nov 7, 2022
juliannguyen4 added a commit that referenced this pull request Nov 18, 2022
* Automatically format code with black
* Remove unused imports
* Fix E722
* Fix E712
* Remove unused variables
* Expand star imports
* Fix undefined name errors
* Remove unnecessary passes, comment out necessary code
* Remove duplicate code
* Fix E711
* Fix E262
* Fix line length errs
* Fix E261
* Fail tests if aerospike isn't installed
* Fix all F811 and other errs
* Rename duplicate methods
* Fix or omit any failing duplicate methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants