-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-1843] Lint test code #301
Merged
juliannguyen4
merged 25 commits into
aerospike:stage
from
juliannguyen4:CLIENT-1843-testcode
Nov 2, 2022
Merged
[CLIENT-1843] Lint test code #301
juliannguyen4
merged 25 commits into
aerospike:stage
from
juliannguyen4:CLIENT-1843-testcode
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command used: |
Additional change: tests will fail if aerospike isn't installed instead of skipping |
juliannguyen4
force-pushed
the
CLIENT-1843-testcode
branch
from
October 20, 2022 18:12
baa35b1
to
e4a298b
Compare
juliannguyen4
force-pushed
the
CLIENT-1843-testcode
branch
from
November 2, 2022 16:04
e4a298b
to
10b7264
Compare
justinlee-aerospike
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Discussed removal of weird import aerospike code with Julian - I agree it should be removed.
juliannguyen4
added a commit
to juliannguyen4/aerospike-client-python
that referenced
this pull request
Nov 7, 2022
This reverts commit ac3e27b.
juliannguyen4
added a commit
that referenced
this pull request
Nov 18, 2022
* Automatically format code with black * Remove unused imports * Fix E722 * Fix E712 * Remove unused variables * Expand star imports * Fix undefined name errors * Remove unnecessary passes, comment out necessary code * Remove duplicate code * Fix E711 * Fix E262 * Fix line length errs * Fix E261 * Fail tests if aerospike isn't installed * Fix all F811 and other errs * Rename duplicate methods * Fix or omit any failing duplicate methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.