Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLIENT-1863] Use pyproject.toml for static metadata #298

Merged
merged 6 commits into from
Oct 20, 2022
Merged

[CLIENT-1863] Use pyproject.toml for static metadata #298

merged 6 commits into from
Oct 20, 2022

Conversation

juliannguyen4
Copy link
Collaborator

No description provided.

@juliannguyen4
Copy link
Collaborator Author

With pyproject.toml, this is what the metadata looks like:

(.venv) jnguyen@as-PF3WN8Y6:~/clients/aerospike-client-python$ pip show aerospike
Name: aerospike
Version: 7.1.1
Summary: Aerospike Client Library for Python
Home-page: 
Author: 
Author-email: "Aerospike, Inc." <[email protected]>
License: Apache Software License
Location: /home/jnguyen/clients/aerospike-client-python/.venv/lib/python3.9/site-packages
Requires: 
Required-by:

With the normal setup.py:

jnguyen@as-PF3WN8Y6:~/clients/aerospike-client-python$ pip show aerospike
Name: aerospike
Version: 7.1.0
Summary: Aerospike Client Library for Python
Home-page: http://aerospike.com
Author: Aerospike, Inc.
Author-email: [email protected]
License: Apache Software License
Location: /home/jnguyen/.pyenv/versions/3.9.13/lib/python3.9/site-packages/aerospike-7.1.0-py3.9-linux-x86_64.egg
Requires: 
Required-by:

@juliannguyen4 juliannguyen4 marked this pull request as ready for review October 14, 2022 20:33
@juliannguyen4
Copy link
Collaborator Author

I updated the build and install instructions in BUILD.md, so this might have important changes

rpandian-spike
rpandian-spike previously approved these changes Oct 15, 2022
View reviewed changes
@juliannguyen4
Copy link
Collaborator Author

@rpandian-spike Is the warning regarding Mac OSX 12 still applicable?

dwelch-spike
dwelch-spike reviewed Oct 19, 2022
View reviewed changes
BUILD.md Outdated Show resolved Hide resolved
dwelch-spike
dwelch-spike approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliannguyen4 juliannguyen4 merged commit 368e56f into aerospike:stage Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwelch-spike dwelch-spike dwelch-spike approved these changes

@rpandian-spike rpandian-spike rpandian-spike left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliannguyen4 @dwelch-spike @rpandian-spike