-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-1854] Python client crashes while doing IO during server upgrade/downgrade #297
Conversation
@rpandian-spike I had some concerns about this PR and I was hoping you could address them.
Alternatively, we could just leave the client constructor code as it is and add a check for a connection before each server operation to prevent a segfault. I prefer this approach since it isn't a breaking change. |
P.S We should also move the changes related to CLIENT-1829 to a different PR, since this PR already addresses CLIENT-1854 |
With this new change, Connect and Close calls are no-ops |
1829 and 1854 are different use cases but same issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and questions.
f071239
to
0da7cbe
Compare
0da7cbe
to
730f76f
Compare
be869c0
to
9512c25
Compare
…nnect/close calls
9512c25
to
dd7caf3
Compare
Co-authored-by: juliannguyen4 <[email protected]>
Addresses the following:
CLIENT-1854 | Python client crashes while doing IO during server upgrade/downgrade
(https://aerospike.atlassian.net/browse/CLIENT-1854)