fix more suppressed errors

aerospike · Aug 28, 2023 · 9c48b2c · 9c48b2c
1 parent 221c2b9
commit 9c48b2c
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 18 deletions.
diff --git a/src/main/client/apply.c b/src/main/client/apply.c
@@ -146,9 +146,6 @@ PyObject *AerospikeClient_Apply_Invoke(AerospikeClient *self, PyObject *py_key,
     if (err.code == AEROSPIKE_OK) {
         val_to_pyobject(self, &err, result, &py_result);
     }
-    else {
-        as_error_update(&err, err.code, NULL);
-    }
 
 CLEANUP:
     if (exp_list_p) {

diff --git a/src/main/client/exists.c b/src/main/client/exists.c
@@ -119,9 +119,6 @@ extern PyObject *AerospikeClient_Exists_Invoke(AerospikeClient *self,
 
         Py_INCREF(py_result_meta);
     }
-    else {
-        as_error_update(&err, err.code, NULL);
-    }
 
 CLEANUP:
 

diff --git a/src/main/client/get.c b/src/main/client/get.c
@@ -114,9 +114,6 @@ PyObject *AerospikeClient_Get_Invoke(AerospikeClient *self, PyObject *py_key,
             PyTuple_SetItem(p_key, 2, Py_None);
         }
     }
-    else {
-        as_error_update(&err, err.code, NULL);
-    }
 
 CLEANUP:
 

diff --git a/src/main/client/operate.c b/src/main/client/operate.c
@@ -880,7 +880,6 @@ static PyObject *AerospikeClient_Operate_Invoke(AerospikeClient *self,
     Py_END_ALLOW_THREADS
 
     if (err->code != AEROSPIKE_OK) {
-        as_error_update(err, err->code, NULL);
         goto CLEANUP;
     }
     /* The op succeeded; it's now safe to free the record */
@@ -1062,7 +1061,6 @@ AerospikeClient_OperateOrdered_Invoke(AerospikeClient *self, as_error *err,
     Py_END_ALLOW_THREADS
 
     if (err->code != AEROSPIKE_OK) {
-        as_error_update(err, err->code, NULL);
         goto CLEANUP;
     }
 

diff --git a/src/main/client/remove_bin.c b/src/main/client/remove_bin.c
@@ -146,10 +146,6 @@ AerospikeClient_RemoveBin_Invoke(AerospikeClient *self, PyObject *py_key,
     Py_BEGIN_ALLOW_THREADS
     aerospike_key_put(self->as, err, write_policy_p, &key, &rec);
     Py_END_ALLOW_THREADS
-    if (err->code != AEROSPIKE_OK) {
-        as_error_update(err, err->code, NULL);
-        goto CLEANUP;
-    }
 
 CLEANUP:
 

diff --git a/src/main/client/select.c b/src/main/client/select.c
@@ -161,9 +161,6 @@ PyObject *AerospikeClient_Select_Invoke(AerospikeClient *self, PyObject *py_key,
         select_succeeded = true;
         record_to_pyobject(self, &err, rec, &key, &py_rec);
     }
-    else {
-        as_error_update(&err, err.code, NULL);
-    }
 
 CLEANUP:
     if (exp_list_p) {
-Original file line number
+Diff line change
@@ Expand Up @@
             Py_INCREF(py_result_meta);
         }
-        else {
-            as_error_update(&err, err.code, NULL);
-        }
     CLEANUP:
@@ Expand Down @@