Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #272 fix #273

Merged
merged 6 commits into from
Dec 23, 2019
Merged

Issue #272 fix #273

merged 6 commits into from
Dec 23, 2019

Conversation

sm4ll-3gg
Copy link
Contributor

@sm4ll-3gg sm4ll-3gg commented Dec 10, 2019 •
edited
Loading

#272 issue-related fix

@khaf
Copy link
Collaborator

khaf commented Dec 10, 2019

Thank you for this pull request. Could you please add tests in client_object_test.go for the cases you fixed?

@sm4ll-3gg
Copy link
Contributor Author

sm4ll-3gg commented Dec 11, 2019 •
edited
Loading

Of course! I've done it in the last few commits.
Sorry for so many commits. I couldn't run tests locally because there are imports of internal packages, and I get errors like client.go:30:2: use of internal package github.com/aerospike/aerospike-client-go/internal/atomic not allowed

@khaf

@khaf khaf merged commit 921497d into aerospike:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sm4ll-3gg @khaf