Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get socket timeout once per command execution #211

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

chapsuk
Copy link

@chapsuk chapsuk commented Oct 11, 2017

Hi, this fix was born from error log message (caller string):

command execution timed out on client: Exceeded number of retries. 
See `Policy.MaxRetries`. (last error: %!s(<nil>))

%!s(<nil>) because err var redefined here for each loop iteration.

Looks like socketTimeout can't change between execution iterations and we can define him once.

With this fix resulting error message looks like this:

command execution timed out on client: Exceeded number of retries. 
See `Policy.MaxRetries`. (last error: No available connections to the node. 
Connection Pool was empty, and limited to certain number of connections.)

@khaf khaf merged commit 279f6d8 into aerospike:master Oct 12, 2017
@chapsuk chapsuk deleted the fix_error_log branch October 16, 2017 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants