Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In case of LimitConnectionsToQueueSize is false, connectionCount is invalid #168

Merged
merged 1 commit into from
Dec 20, 2016
Merged

In case of LimitConnectionsToQueueSize is false, connectionCount is invalid #168

merged 1 commit into from
Dec 20, 2016

Conversation

bluele
Copy link
Contributor

@bluele bluele commented Dec 18, 2016

Hi there.
It seems that connectionCount is always invalid value when LimitConnectionsToQueueSize is false.

@khaf
Copy link
Collaborator

khaf commented Dec 18, 2016

In this case the better idea would be to reverse the order to avoid the short circuit, don't you think?

@bluele bluele changed the title fix invalid connectionCount In case of LimitConnectionsToQueueSize is false, connectionCount is invalid Dec 18, 2016
@bluele
Copy link
Contributor Author

bluele commented Dec 18, 2016

Yes. In addition, I think that an explicit declaration would be better.

@khaf
Copy link
Collaborator

khaf commented Dec 18, 2016 •
edited
Loading

Edited: What I said was invalid.

@khaf khaf merged commit fc68e16 into aerospike:master Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluele @khaf