use internal random number generator + tests

added client.ListUDF() and client.RemoveUDF() and tests
wait for migrations to finish before query, scan, batch and executeUDF commands
major code clean up

.travis.yml

@@ -11,7 +11,7 @@ install:
   - go get github.com/onsi/ginkgo/ginkgo
   - go get github.com/onsi/gomega
   - go get code.google.com/p/go.tools/cmd/cover
-  - wget -O aerospike-server.tgz http://aerospike.com/download/server/3.3.5/artifact/tgz
+  - wget -O aerospike-server.tgz http://aerospike.com/download/server/3.3.12/artifact/tgz
   - tar xvzf aerospike-server.tgz
   - cp -f .travis/aerospike.conf ./aerospike-server/share/etc
   - cd aerospike-server

batch_command.go

@@ -38,7 +38,6 @@ type baseMultiCommand struct {
 	Records chan *Record
 	Errors  chan error
 
-	conn  *Connection
 	valid bool //= true
 	mutex sync.RWMutex
 }
@@ -59,7 +58,6 @@ func (cmd *baseMultiCommand) getNode(ifc command) (*Node, error) {
 func (cmd *baseMultiCommand) parseResult(ifc command, conn *Connection) error {
 	// Read socket into receive buffer one record at a time.  Do not read entire receive size
 	// because the receive buffer would be too big.
-	cmd.conn = conn
 	status := true
 
 	for status {

batch_item.go

@@ -54,9 +54,8 @@ func (bi *batchItem) AddDuplicate(idx int) {
 func (bi *batchItem) GetIndex() int {
 	if bi.duplicates == nil {
 		return bi.index
-	} else {
-		r := bi.duplicates[bi.index]
-		bi.index++
-		return r
 	}
+	r := bi.duplicates[bi.index]
+	bi.index++
+	return r
 }