APPS-1436 Add static fields validation in update config handler #299
+171
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #299 +/- ##
==========================================
+ Coverage 44.01% 45.35% +1.33%
==========================================
Files 52 52
Lines 2851 2851
==========================================
+ Hits 1255 1293 +38
+ Misses 1470 1424 -46
- Partials 126 134 +8 ☔ View full report in Codecov by Sentry. |
reugn
changed the title
reugn
approved these changes
Jan 1, 2025
pkg/service/config_applier.go
Outdated
| @@ -18,6 +18,7 @@ type ConfigApplier interface { | |||
| } | |||
|
|
|||
| type DefaultConfigApplier struct { | |||
| mu sync.RWMutex | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.