Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1400 Remove EXTERNAL_INSECURE auth mode #290

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.95%. Comparing base (0dce781) to head (15a73ff).

Files with missing lines Patch % Lines
pkg/dto/aerospike_cluster.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #290      +/-   ##
==========================================
+ Coverage   43.94%   43.95%   +0.01%     
==========================================
  Files          52       52              
  Lines        2849     2855       +6     
==========================================
+ Hits         1252     1255       +3     
- Misses       1472     1474       +2     
- Partials      125      126       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review December 23, 2024 13:31
@korotkov-aerospike korotkov-aerospike merged commit 49b9e8e into v2 Dec 23, 2024
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the APPS-1400/Remove-EXTERNAL_INSECURE branch December 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants