Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1383 Support Secret Agent keys for GCP and Azure credentials configuration #281

Merged
merged 11 commits into from
Dec 9, 2024

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@korotkov-aerospike korotkov-aerospike changed the title APPS-1383 Add gcp secret agent APPS-1383 Support Secret Agent keys for GCP credentials configuration Dec 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 55.24476% with 64 lines in your changes missing coverage. Please review.

Project coverage is 41.07%. Comparing base (e02d6c5) to head (449423b).

Files with missing lines Patch % Lines
pkg/service/storage/azure.go 0.00% 22 Missing ⚠️
pkg/dto/storage_azure.go 76.27% 10 Missing and 4 partials ⚠️
pkg/service/storage/gcp.go 0.00% 11 Missing ⚠️
pkg/dto/storage_gcp.go 70.00% 6 Missing and 3 partials ⚠️
pkg/dto/storage_local.go 46.15% 6 Missing and 1 partial ⚠️
pkg/dto/storage.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #281      +/-   ##
==========================================
+ Coverage   38.28%   41.07%   +2.79%     
==========================================
  Files          46       49       +3     
  Lines        2641     2688      +47     
==========================================
+ Hits         1011     1104      +93     
+ Misses       1505     1455      -50     
- Partials      125      129       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korotkov-aerospike korotkov-aerospike changed the title APPS-1383 Support Secret Agent keys for GCP credentials configuration APPS-1383 Support Secret Agent keys for GCP and Azure credentials configuration Dec 8, 2024
@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review December 8, 2024 11:23
@korotkov-aerospike
Copy link
Contributor Author

@davi17g should test functionality before merge

@davi17g davi17g self-requested a review December 9, 2024 15:03
@korotkov-aerospike korotkov-aerospike merged commit d118935 into v2 Dec 9, 2024
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the APPS-1383/SecretsForGcp branch December 9, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants