Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage root folder prefix to startAfter flag #270

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.78%. Comparing base (f83837b) to head (abc7be8).

Files with missing lines Patch % Lines
pkg/service/storage/operations.go 0.00% 2 Missing ⚠️
pkg/service/storage/azure.go 0.00% 1 Missing ⚠️
pkg/service/storage/gcp.go 0.00% 1 Missing ⚠️
pkg/service/storage/s3.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #270      +/-   ##
==========================================
- Coverage   29.79%   29.78%   -0.02%     
==========================================
  Files          41       41              
  Lines        2346     2347       +1     
==========================================
  Hits          699      699              
- Misses       1556     1557       +1     
  Partials       91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review November 25, 2024 11:23
Copy link
Contributor

@filkeith filkeith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korotkov-aerospike korotkov-aerospike merged commit 4ff9568 into v2 Nov 25, 2024
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the fullPathAfter branch November 25, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants