Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1354 Relax storage configuration validation for GCP and Azure #267

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 30.47%. Comparing base (71e60a9) to head (ac452dc).

Files with missing lines Patch % Lines
pkg/dto/storage.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #267      +/-   ##
==========================================
+ Coverage   29.79%   30.47%   +0.68%     
==========================================
  Files          41       41              
  Lines        2346     2346              
==========================================
+ Hits          699      715      +16     
+ Misses       1556     1537      -19     
- Partials       91       94       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review November 25, 2024 11:22
@korotkov-aerospike
Copy link
Contributor Author

@davi17g confirmed that GCP works.

@korotkov-aerospike korotkov-aerospike merged commit 91ab9dc into v2 Nov 25, 2024
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the storageValidation branch November 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants