Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1338 Fix nil dereference on backup reading #259

Merged
merged 6 commits into from
Nov 17, 2024

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@korotkov-aerospike korotkov-aerospike changed the title Apps-1338 Fix nil dereference on backup reading APPS-1338 Fix nil dereference on backup reading Nov 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 30.03%. Comparing base (44e936e) to head (eed3663).

Files with missing lines Patch % Lines
pkg/dto/base_dto.go 0.00% 4 Missing ⚠️
pkg/dto/backup_details.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #259      +/-   ##
==========================================
- Coverage   30.68%   30.03%   -0.65%     
==========================================
  Files          41       41              
  Lines        2327     2327              
==========================================
- Hits          714      699      -15     
- Misses       1519     1537      +18     
+ Partials       94       91       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review November 17, 2024 16:22
@korotkov-aerospike korotkov-aerospike requested review from reugn and filkeith and removed request for reugn November 17, 2024 16:22
@korotkov-aerospike
Copy link
Contributor Author

korotkov-aerospike commented Nov 17, 2024

I had updated lib version and added few more logs.
All tests on Jenkins passed.

@korotkov-aerospike korotkov-aerospike merged commit 0ea4753 into v2 Nov 17, 2024
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the APPS-1338/dereferenceOnBackupReading branch November 17, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants