Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1334 Reuse RetryPolicy in BackupPolicy #256

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 15 lines in your changes missing coverage. Please review.

Project coverage is 30.68%. Comparing base (091a955) to head (9539d36).

Files with missing lines Patch % Lines
pkg/dto/retry_policy.go 0.00% 12 Missing ⚠️
pkg/dto/backup_policy.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #256      +/-   ##
==========================================
+ Coverage   30.31%   30.68%   +0.36%     
==========================================
  Files          41       41              
  Lines        2319     2327       +8     
==========================================
+ Hits          703      714      +11     
+ Misses       1521     1519       -2     
+ Partials       95       94       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	pkg/service/backup_routine_handler.go
#	pkg/service/backup_routine_handler_test.go
#	pkg/service/retry_service.go
#	pkg/service/retry_service_test.go
#	pkg/service/retryable_backup_handler_test.go
@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review November 14, 2024 14:09
@korotkov-aerospike korotkov-aerospike merged commit 44e936e into v2 Nov 14, 2024
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the retry_config branch November 14, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants