Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor routine handler infrastructure #251

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 36 lines in your changes missing coverage. Please review.

Project coverage is 28.50%. Comparing base (a09a171) to head (5a74d65).

Files with missing lines Patch % Lines
pkg/service/cluster_config_writer.go 0.00% 20 Missing ⚠️
pkg/service/paths.go 48.38% 14 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #251      +/-   ##
==========================================
+ Coverage   27.79%   28.50%   +0.71%     
==========================================
  Files          39       40       +1     
  Lines        2245     2273      +28     
==========================================
+ Hits          624      648      +24     
- Misses       1529     1533       +4     
  Partials       92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reugn reugn changed the title Routine handler refactoring Refactor routine handler infrastructure Nov 11, 2024
pkg/service/paths.go Outdated Show resolved Hide resolved
pkg/service/backup_routine_handler.go Show resolved Hide resolved
@korotkov-aerospike korotkov-aerospike merged commit d9159a5 into v2 Nov 11, 2024
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the routine_handler branch November 11, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants