APPS-1321 Add support for configuring Aerospike cluster password in Secret Agent #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korotkov-aerospike
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #248 +/- ##
==========================================
- Coverage 28.09% 27.79% -0.30%
==========================================
Files 39 39
Lines 2189 2245 +56
==========================================
+ Hits 615 624 +9
- Misses 1489 1529 +40
- Partials 85 92 +7 ☔ View full report in Codecov by Sentry. |
|
We are currently running tests on AWS to actually use SA |
reugn
approved these changes
Nov 6, 2024
pkg/model/aerospike_cluster.go
Outdated
Comment on lines
119
to
120
| "agent", agent, | ||
| "err", err) |
There was a problem hiding this comment.
Use slog.Attr functions to construct arguments.
pkg/dto/secret_agent.go
Outdated
| return nil | ||
| } | ||
|
|
||
| if s.Address == nil || (s.Address != nil && *s.Address == "") { |
There was a problem hiding this comment.
The s.Address != nil check is redundant here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.