Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1268 Validate backup/restore namespace exists #244

Merged
merged 13 commits into from
Nov 4, 2024

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review October 23, 2024 11:07
pkg/service/backup_go.go Outdated Show resolved Hide resolved
pkg/service/backup_go.go Outdated Show resolved Hide resolved
pkg/service/aerospike_service.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 58.65385% with 43 lines in your changes missing coverage. Please review.

Project coverage is 28.73%. Comparing base (f35916d) to head (2a7162e).

Files with missing lines Patch % Lines
pkg/service/restore_data.go 21.73% 16 Missing and 2 partials ⚠️
pkg/dto/restore_request.go 0.00% 12 Missing ⚠️
pkg/service/client_manager.go 89.58% 4 Missing and 1 partial ⚠️
pkg/dto/backup_routine.go 40.00% 2 Missing and 1 partial ⚠️
pkg/dto/config.go 57.14% 2 Missing and 1 partial ⚠️
pkg/service/config_applier.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #244      +/-   ##
==========================================
+ Coverage   27.75%   28.73%   +0.97%     
==========================================
  Files          39       39              
  Lines        2104     2168      +64     
==========================================
+ Hits          584      623      +39     
- Misses       1437     1457      +20     
- Partials       83       88       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korotkov-aerospike
Copy link
Contributor Author

I've introduced nsValidator component that does the info request and validates namespaces.
If aerospike is unavailable, validation is skipped.
I do it when the config is updated, or routine or cluster. It had added a bit of complexity, but I think it's worth it.

@korotkov-aerospike korotkov-aerospike changed the title APPS-1268 Validate namespace exists before backup APPS-1268 Validate backup/restore namespace exists Oct 23, 2024
pkg/service/aerospike_service.go Show resolved Hide resolved
pkg/service/restore_data.go Outdated Show resolved Hide resolved
@korotkov-aerospike korotkov-aerospike merged commit 5b787d0 into v2 Nov 4, 2024
4 checks passed
@korotkov-aerospike korotkov-aerospike deleted the unexistingNS branch November 4, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants