-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APPS-1308 Update Apply config endpoint #243
Conversation
korotkov-aerospike
commented
Oct 10, 2024
•
edited
Loading
edited
- on app startup moved instantiation on top level, reducing number of params
- configuration manager return model.Config on read
- make configuration manager impls private
- (most important) on each CRUD operation call changeConfig method, that updates config, saves it and applies.
- on reschedule leave ad-hoc jobs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #243 +/- ##
==========================================
- Coverage 29.97% 27.75% -2.23%
==========================================
Files 37 39 +2
Lines 1948 2104 +156
==========================================
Hits 584 584
- Misses 1281 1437 +156
Partials 83 83 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the refactoring require regenerating OpenAPI spec?