APPS-1283 Introduce DTO layer #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update-go-lib - added extra-ttl support - new s3 client initialization - .Wait(ctx) with context
…APPS-1283/DTO_refactoring # Conflicts: # internal/server/dto/restore_namespace.go # pkg/model/backup_routine.go # pkg/model/restore_policy.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #230 +/- ##
===========================================
- Coverage 80.65% 39.00% -41.66%
===========================================
Files 14 30 +16
Lines 641 1564 +923
===========================================
+ Hits 517 610 +93
- Misses 97 876 +779
- Partials 27 78 +51 ☔ View full report in Codecov by Sentry. |
# Conflicts: # cmd/backup/main.go # internal/server/configuration/configuration_manager.go # internal/server/configuration/configuration_manager_local.go # internal/server/handlers/backup.go # internal/server/handlers/config.go # internal/server/handlers/config_cluster.go # internal/server/handlers/config_cluster_test.go # internal/server/handlers/config_policy.go # internal/server/handlers/config_policy_test.go # internal/server/handlers/config_routine.go # internal/server/handlers/config_routines_test.go # internal/server/handlers/config_storage.go # internal/server/handlers/config_storage_test.go # internal/server/handlers/config_test.go # internal/server/handlers/handlers_test.go # internal/server/handlers/restore.go # internal/server/handlers/restore_test.go # internal/server/handlers/service.go # internal/server/server.go # pkg/model/backup_policy.go # pkg/model/config_default.go # pkg/model/restore_policy.go # pkg/service/configuration_manager_http.go # pkg/service/configuration_manager_s3.go # pkg/service/configuration_manager_test.go # pkg/service/configuration_service_cluster.go # pkg/service/configuration_service_cluster_test.go # pkg/service/configuration_service_policy.go # pkg/service/configuration_service_policy_test.go # pkg/service/configuration_service_routine.go # pkg/service/configuration_service_routine_test.go # pkg/service/configuration_service_storage.go # pkg/service/configuration_service_storage_test.go # pkg/service/restore_go.go # pkg/service/s3_context_test.go # pkg/service/storage_accessor.go
|
Brief overview:
all tests pass: http://3.65.168.247:8080/ui/#backup/launches/all |
reugn
reviewed
Sep 3, 2024
reugn
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.