This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
feat: allow for adding conflict listeners after client creation #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Composite Conflict Listener class that can accept register and remove individual listener functions as needed | ||
| * Gets passed down to the conflict link | ||
| */ | ||
| export class CompositeConflictListener implements ConflictListener { |
There was a problem hiding this comment.
Awesome, does this mean the changes aren't even breaking changes?
There was a problem hiding this comment.
exactly, you can still pass your original conflictListener in options if desired but it'll get registered into this Composite one.
kingsleyzissou
approved these changes
Mar 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
CompositeConflictListenerclass that always gets passed down to theConflictLink. This allows us to add/remove listeners as needed. It's quick and dirty but it works and it has an integration test.Checklist
npm testpassesnpm run buildworks