This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Datastore network indicator (fixes #1069) #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published |
wtrocki
reviewed
Feb 25, 2021
| @@ -16,7 +16,7 @@ | |||
| "@types/react-dom": "^16.9.0", | |||
| "antd": "~4.4.1", | |||
| "graphql.macro": "^1.4.2", | |||
| "offix-datastore": "0.3.17", | |||
| "offix-datastore": "0.3.19", | |||
There was a problem hiding this comment.
Awesome will do that now
wtrocki
reviewed
Feb 25, 2021
examples/react-datastore/src/App.tsx
Outdated
| } | ||
| setReplicating(!replicating) | ||
| } | ||
| // const toggleReplication = () => { |
There was a problem hiding this comment.
Oh should have deleted. I removed it now because I have the change in network status stopping and starting the replication automatically
There was a problem hiding this comment.
That should happen anyway in the core right?
There was a problem hiding this comment.
Yeah, this is more for the OVP stuff, because turning switching to offline mode in chrome doesn't really stop the replication or subscriptions from coming in.
wtrocki
approved these changes
Feb 25, 2021
kingsleyzissou
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testpassesnpm run buildworks