Change uint64 to bytes for supporting big number #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's not compiled yet
- transaction's amount and price should be written in "string", not number format
graup
reviewed
Dec 4, 2018
| @@ -155,7 +156,7 @@ func TestVerfiyFail(t *testing.T) { | |||
| assert.NotNil(t, tx.Body.Sign, "failed to sign") | |||
|
|
|||
| //edit tx after sign | |||
| tx.Body.Amount = 0xff | |||
| tx.Body.Amount = new(big.Int).SetUint64(0xff).Bytes() | |||
There was a problem hiding this comment.
Isn't big.NewInt(0xff).Bytes() the same as new(big.Int).SetUint64(0xff).Bytes()?
There was a problem hiding this comment.
right 👍 I will fix :)
edit
it's different, Int vs Uint.
no need to use SetUint64 at that case, some others should use SetUint64
I changed all the value using macro.
| } | ||
|
|
||
| tx := &types.Tx{ | ||
| Body: &types.TxBody{ | ||
| Account: account, | ||
| Recipient: []byte(types.AergoSystem), | ||
| Amount: amount, | ||
| Price: 0, | ||
| Amount: amountBigInt.Bytes(), |
There was a problem hiding this comment.
Just a question, what is the point of calling Bytes()? Is it to create a copy?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16