Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper set library to facilitate implementation of the new health check procedure #252

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

lllamnyp
Copy link
Collaborator

@lllamnyp lllamnyp commented Jul 11, 2024

This is the first PR in a series of stacked PRs, aimed ultimately at implementing the features described in #181 and #207. The next PR in the stack can be found at #259.

pkg/set/set.go Show resolved Hide resolved
@lllamnyp lllamnyp changed the title Add a set library stub and use it to improve observables' checks Draft: Continue to implement #181 flowchart logic Jul 29, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 29, 2024
@kvaps kvaps mentioned this pull request Jul 30, 2024
29 tasks
A set library is useful for several healthcheck operations, such as verifying that several etcd members share a single unique cluster ID.
@lllamnyp lllamnyp changed the title Draft: Continue to implement #181 flowchart logic Add a helper set library to facilitate implementation of the new health check procedure Aug 12, 2024
@lllamnyp lllamnyp marked this pull request as ready for review August 12, 2024 19:56
@lllamnyp lllamnyp mentioned this pull request Aug 13, 2024
6 tasks
Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps kvaps merged commit 28b0def into main Aug 15, 2024
9 checks passed
@kvaps kvaps deleted the feat/new-status-check branch August 15, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controllers documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants