Flux Operator 0.16 #650
Flux Operator 0.16 #650
Conversation
Signed-off-by: Kingdon B <[email protected]>
dosubot
bot
added
the
size:M
WalkthroughThe pull request updates two Helm charts for Flux Operator and Flux Instance. Version numbers in Changes
Sequence Diagram(s)sequenceDiagram
participant HelmChart as Helm Chart
participant Values as Values File
participant Deployment as Deployment Template
participant Cluster as Kubernetes Cluster
HelmChart->>Values: Reads imagePullPolicy value (default "IfNotPresent")
Values->>Deployment: Passes imagePullPolicy setting
Deployment->>Cluster: Applies dynamic imagePullPolicy configuration
sequenceDiagram
participant HelmChart as Helm Chart
participant Values as Values File
participant Template as Instance Template
participant FluxInstance as Flux Instance
HelmChart->>Values: Reads sync.provider value
Values->>Template: Passes provider value if defined
Template->>FluxInstance: Sets provider field in sync configuration
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
dosubot
bot
added
documentation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/system/fluxcd/charts/flux-instance/README.md (1)
50-52: Convert Bare URLs in Source Code SectionConsider replacing bare URL presentations with proper Markdown link format for improved readability and to adhere to markdown best practices (e.g.,
[Flux Operator](https://github.com/controlplaneio-fluxcd/flux-operator)).🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
52-52: Unordered list style
Expected: dash; Actual: asterisk(MD004, ul-style)
packages/system/fluxcd-operator/charts/flux-operator/README.md (1)
62-64: Convert Bare URLs to Markdown LinksIt is recommended to format bare URLs as Markdown links (e.g.,
[Flux Operator](https://github.com/controlplaneio-fluxcd/flux-operator)) in the “Source Code” section for enhanced readability and to comply with markdown linters.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
62-62: Unordered list style
Expected: dash; Actual: asterisk(MD004, ul-style)
63-63: Unordered list style
Expected: dash; Actual: asterisk(MD004, ul-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
packages/system/fluxcd-operator/charts/flux-operator/Chart.yaml(2 hunks)packages/system/fluxcd-operator/charts/flux-operator/README.md(2 hunks)packages/system/fluxcd-operator/charts/flux-operator/templates/crds.yaml(1 hunks)packages/system/fluxcd-operator/charts/flux-operator/templates/deployment.yaml(1 hunks)packages/system/fluxcd-operator/charts/flux-operator/values.schema.json(1 hunks)packages/system/fluxcd-operator/charts/flux-operator/values.yaml(1 hunks)packages/system/fluxcd/charts/flux-instance/Chart.yaml(2 hunks)packages/system/fluxcd/charts/flux-instance/README.md(2 hunks)packages/system/fluxcd/charts/flux-instance/templates/instance.yaml(1 hunks)packages/system/fluxcd/charts/flux-instance/values.schema.json(1 hunks)packages/system/fluxcd/charts/flux-instance/values.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/system/fluxcd/charts/flux-instance/Chart.yaml
- packages/system/fluxcd-operator/charts/flux-operator/Chart.yaml
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
packages/system/fluxcd/charts/flux-instance/README.md
47-47: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (11)
packages/system/fluxcd/charts/flux-instance/values.yaml (1)
48-48: New Provider Field in Sync ConfigurationThe addition of the
provider: ""field under thesyncsection provides a clean way for users to specify a sync provider. This change aligns well with the broader update and schema modifications. Ensure that accompanying documentation or examples reflect this new option if necessary.packages/system/fluxcd-operator/charts/flux-operator/values.schema.json (1)
97-104: Addition of imagePullPolicy to Image SchemaThe new
imagePullPolicyproperty is well-defined with enumerated values (IfNotPresent,Always,Never). This enhancement allows for flexible control over image pulling behavior. Verify that the deployment template correctly references this dynamic value.packages/system/fluxcd/charts/flux-instance/templates/instance.yaml (1)
50-52: Conditional Rendering of Provider in Sync ConfigurationThe conditional block using
{{- if .Values.instance.sync.provider }}is implemented correctly. It ensures that theproviderfield is only rendered when a value is provided, maintaining a clean output configuration.packages/system/fluxcd-operator/charts/flux-operator/values.yaml (1)
26-26: Configure Image Pull Policy in ValuesIntroducing
imagePullPolicy: IfNotPresentunder theimagesection provides a sensible default that complements the schema changes. This update allows end users to override the pull policy as needed.packages/system/fluxcd/charts/flux-instance/values.schema.json (1)
151-153: Extension of Sync Schema with Provider FieldAdding the
providerproperty to thesyncobject in the schema correctly extends the configuration to support the new provider option. This change ensures that any configuration adhering to the schema can now include a provider for source authentication.packages/system/fluxcd-operator/charts/flux-operator/templates/deployment.yaml (1)
83-83: Dynamic Image Pull Policy ConfiguredThe use of
{{ .Values.image.imagePullPolicy }}makes the image pull policy configurable via the values file. This change enhances deployment flexibility and ensures that users can override the default (typically "IfNotPresent") as needed.packages/system/fluxcd-operator/charts/flux-operator/templates/crds.yaml (1)
304-316: New 'provider' Field for OIDC AuthenticationThe addition of the
providerfield in the sync configuration offers enhanced control over OIDC authentication for different source kinds. The enumerated values (generic,aws,azure,gcp,github) appropriately cover the expected providers. Please verify that downstream processes or controllers correctly interpret this field based on the source kind.packages/system/fluxcd/charts/flux-instance/README.md (2)
3-3: Version Badge UpdateThe version badge has been updated to 0.16.0, ensuring that the documentation correctly reflects the new release version of the chart.
47-47: Updated Sync Configuration with 'provider' FieldThe
instance.syncconfiguration now includes the newproviderfield. This update allows users to specify the OIDC provider for source authentication. Please make sure this change is also documented in the related schema and configuration instructions.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
47-47: Bare URL used
null(MD034, no-bare-urls)
packages/system/fluxcd-operator/charts/flux-operator/README.md (2)
3-3: Version Badge UpdateThe version badge now reflects the updated version (0.16.0), ensuring that users immediately see the current release information.
42-42: Updated Image ConfigurationThe image configuration has been enhanced by adding an
imagePullPolicykey with a default value of"IfNotPresent". This gives users more explicit control over the image pull behavior, improving consistency with Kubernetes best practices.
Another update - this time Flux Operator adds support for the
sync.providerfield in theFluxInstance.spec, so users can take advantage of the new GitHub App support to build syncs in a way that have more finely scoped permissions, and to rotate the deploy key automatically.And other changes which you can read about here:
Summary by CodeRabbit
New Features
Documentation
Chores