Add Virtual Machine (simple) #430
Conversation
WalkthroughThe pull request introduces updates to the versioning and configuration of the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 14
🧹 Outside diff range and nitpick comments (17)
packages/apps/virtual-machine/templates/secret.yaml (1)
1-11: LGTM with a minor formatting fix.The SSH Keys Secret definition looks good overall. The conditional rendering, naming convention, and data population are implemented correctly.
However, there's a minor formatting issue:
Remove the trailing space on line 9:
- key{{ $k }}: {{ quote $v }} + key{{ $k }}: {{ quote $v }}🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
[error] 9-9: trailing spaces
(trailing-spaces)
packages/apps/virtual-machine/templates/service.yaml (1)
9-20: LGTM: Service specification is well-implemented with a minor suggestion.The Service specification is correctly defined with good practices such as:
- Dynamic Service type based on
.Values.external- Local external traffic policy for improved performance and security
- Disabled node port allocation for the load balancer
- Correct selector matching the metadata labels
- Dynamic port generation using
.Values.externalPortsConsider adding a default port in case
.Values.externalPortsis empty to ensure the Service always has at least one port defined. Here's a suggested implementation:ports: {{- if .Values.externalPorts }} {{- range .Values.externalPorts }} - name: port-{{ . }} port: {{ . }} targetPort: {{ . }} {{- end }} {{- else }} - name: default port: 80 targetPort: 80 {{- end }}packages/apps/virtual-machine/Makefile (4)
4-4: LGTM: Automated README generation.Automating the README generation is a great practice. It ensures that the documentation stays up-to-date with the latest values and schema.
Consider adding a comment explaining the purpose of this command for better maintainability.
5-8: LGTM with suggestions: Instance types and preferences update.The commands effectively extract data from YAML files and update the schema. This automation ensures consistency between the schema and available options.
Consider the following improvements:
- Extract the common
yqoperations into a separate shell function or Make variable to reduce duplication.- Add comments explaining the purpose of each command for better maintainability.
- Consider breaking long lines for better readability, using Makefile line continuation (backslash).
Example refactoring:
define update_schema ITEMS=$$(yq e '.metadata.name' -o=json -r $(1) | yq 'split(" ") | . + [""]' -o json) \ && yq -i -o json ".properties.$(2).optional=true | .properties.$(2).enum = $${ITEMS}" values.schema.json endef generate: readme-generator -v values.yaml -s values.schema.json -r README.md # Update instance types in schema $(call update_schema,../../system/kubevirt-common-instancetypes/templates/instancetypes.yaml,instanceType) # Update instance profiles in schema $(call update_schema,../../system/kubevirt-common-instancetypes/templates/preferences.yaml,instanceProfile)This refactoring reduces duplication and improves readability.
9-9: LGTM: External ports type update.Ensuring that external ports are defined as integers in the schema is a good practice for data validation.
Consider adding a comment explaining the purpose of this update for better maintainability:
# Ensure external ports are defined as integers in the schema yq -i -o json '.properties.externalPorts.items.type = "integer"' values.schema.json
1-9: Overall: Good automation with room for improvementThe new
generatetarget effectively automates several important tasks, including README generation and schema updates. This automation is crucial for maintaining consistency between documentation, schema, and available options.Consider the following suggestions for further improvement:
- Add a comment at the beginning of the file explaining the purpose of the
generatetarget and its dependencies.- Consider breaking down the
generatetarget into smaller, more focused targets (e.g.,update-schema,generate-readme) for better modularity and potential reuse.- Add error handling for the external commands to ensure the build fails if any of these crucial steps fail.
- Document the required versions of the external tools (
readme-generator,yq) to ensure reproducibility.Example:
# This Makefile automates the generation of README and schema updates for the virtual-machine package. # Dependencies: readme-generator, yq (version X.Y or higher) include ../../../scripts/package.mk .PHONY: generate update-schema generate-readme generate: update-schema generate-readme update-schema: # ... (schema update commands with error handling) generate-readme: # ... (README generation command with error handling)These changes would improve the maintainability and robustness of the build process.
packages/apps/virtual-machine/Chart.yaml (1)
2-2: Remove commented out code.The commented out name
#name: Virtual Machineis no longer needed and should be removed to keep the file clean.packages/apps/virtual-machine/values.yaml (5)
3-7: LGTM! Consider adding a security note.The external access configuration looks good. It's secure by default with
external: falseand only forwards the SSH port.Consider adding a comment recommending users to carefully consider security implications before enabling external access and opening additional ports.
9-16: LGTM! Consider enhancing flexibility.The VM state and type configuration is clear and straightforward.
To enhance flexibility, consider:
- Adding comments explaining the available options for
instanceTypeandinstanceProfile.- Providing a link to documentation detailing these options.
This would help users customize the VM configuration more effectively.
33-39: Enhance SSH key configuration and documentation.The SSH key configuration is flexible and secure by default.
Consider the following enhancements:
- Add a comment explaining the security implications of not providing SSH keys (e.g., "No SSH access will be possible without keys").
- Provide instructions on how to generate and add SSH keys for users who might be unfamiliar with the process.
- Consider adding a validation check in the deployment process to warn users if no SSH keys are provided, as this might lead to inaccessible VMs.
41-51: Enhance cloud-init configuration and documentation.The cloud-init configuration provides a good starting point with helpful documentation links.
Consider the following enhancements:
- Provide a more comprehensive example that includes common use cases (e.g., installing packages, creating users, setting up basic security).
- Add comments explaining the purpose and importance of cloud-init for VM initialization.
- Include a warning about potential security implications of certain cloud-init configurations (e.g., setting passwords).
Example of a more comprehensive cloud-init configuration:
cloudInit: | #cloud-config packages: - htop - vim users: - name: admin sudo: ALL=(ALL) NOPASSWD:ALL shell: /bin/bash ssh_authorized_keys: - ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC0g+ZTxC7weoIJLUafOgrm+h... runcmd: - [ufw, allow, OpenSSH] - [ufw, enable]
1-51: Overall good configuration with room for improvement.The
values.yamlfile provides a comprehensive and well-structured configuration for virtual machine deployment. The use of comments to describe parameters is commendable.To further enhance the file:
- Consider adding a brief introduction at the top of the file explaining its purpose and how to use it.
- Group related parameters into logical sections with clear headings for better organization.
- Provide more examples and explanations for complex configurations (e.g., cloud-init, resource allocation).
- Include links to relevant documentation for each major section.
- Consider adding validation for critical parameters to prevent misconfigurations.
These improvements will make the file more user-friendly and reduce the likelihood of deployment issues due to misconfiguration.
🧰 Tools
🪛 yamllint
[error] 21-21: trailing spaces
(trailing-spaces)
packages/apps/versions_map (1)
80-85: LGTM! Consider adding a comment for major version changes in the future.The newly added
virtual-machinepackage entries are well-structured and follow the established pattern in the file. The versions are correctly ordered, and the use of commit hashes (including HEAD for the latest version) is consistent with other packages.For future updates, consider adding a brief comment when introducing major version changes (e.g., from 0.x.x to 1.0.0) to highlight significant milestones or breaking changes. This can help with tracking the package's evolution.
packages/apps/virtual-machine/templates/vm.yaml (2)
14-25: Consider making the default running state configurable.The spec section is well-structured with conditional inclusion of instanceType and instanceProfile. However, the default running state is set to "true", which might not be suitable for all use cases.
Consider modifying line 15 to allow for a configurable default:
- running: {{ .Values.running | default "true" }} + running: {{ .Values.running | default .Values.defaultRunningState | default "true" }}This change would allow users to set a default running state in their values file, while still maintaining the current behavior if not specified.
89-89: Consider making terminationGracePeriodSeconds configurable.The terminationGracePeriodSeconds is currently hardcoded to 30 seconds, which might not be suitable for all workloads.
Consider modifying line 89 to allow for a configurable value:
- terminationGracePeriodSeconds: 30 + terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds | default 30 }}This change would allow users to specify a custom terminationGracePeriodSeconds in their values file, while maintaining the current default if not specified.
packages/apps/virtual-machine/README.md (2)
1-10: LGTM! Consider adding a brief KubeVirt description.The introduction and deployment details are well-written and informative. The links to the KubeVirt User Guide and GitHub repository are helpful. To improve this section further, consider adding a brief one-sentence description of KubeVirt for readers who may not be familiar with it.
12-33: Enhance code block readabilityThe instructions for accessing the virtual machine are clear and comprehensive. To improve the formatting and readability of the code blocks, consider adding language specifications:
-``` +```bash virtctl console <vm>-
+bash
virtctl vnc-``` +```bash virtctl ssh <user>@<vm>This change will enable syntax highlighting for the commands, making them easier to read and distinguish from the surrounding text. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 Markdownlint</summary><blockquote> 19-19: null Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 25-25: null Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 31-31: null Fenced code blocks should have a language specified (MD040, fenced-code-language) </blockquote></details> </details> </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** <details> <summary>📥 Commits</summary> Files that changed from the base of the PR and between 4812874389c3b5a880a641b26189021da5b36f1e and 3841821a42772f7480983d4db66b9391dd444452. </details> <details> <summary>⛔ Files ignored due to path filters (1)</summary> * `packages/apps/virtual-machine/logos/vm.svg` is excluded by `!**/*.svg` </details> <details> <summary>📒 Files selected for processing (13)</summary> * packages/apps/versions_map (1 hunks) * packages/apps/virtual-machine/.helmignore (1 hunks) * packages/apps/virtual-machine/Chart.yaml (1 hunks) * packages/apps/virtual-machine/Makefile (1 hunks) * packages/apps/virtual-machine/README.md (1 hunks) * packages/apps/virtual-machine/hack/update-instance-types.sh (1 hunks) * packages/apps/virtual-machine/templates/_helpers.tpl (1 hunks) * packages/apps/virtual-machine/templates/secret.yaml (1 hunks) * packages/apps/virtual-machine/templates/service.yaml (1 hunks) * packages/apps/virtual-machine/templates/vm.yaml (1 hunks) * packages/apps/virtual-machine/values.schema.json (1 hunks) * packages/apps/virtual-machine/values.yaml (1 hunks) * packages/extra/versions_map (1 hunks) </details> <details> <summary>✅ Files skipped from review due to trivial changes (2)</summary> * packages/apps/virtual-machine/.helmignore * packages/apps/virtual-machine/hack/update-instance-types.sh </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🪛 LanguageTool</summary><blockquote> <details> <summary>packages/apps/virtual-machine/README.md</summary><blockquote> [style] ~51-~51: To form a complete sentence, be sure to include a subject or ‘there’. Context: ... of SSH public keys for authentication. Can be a single key or a list of keys. | `[... (MISSING_IT_THERE) --- [typographical] ~70-~70: Usually, there’s no comma before “if”. Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl... (IF_NO_COMMA) --- [typographical] ~86-~86: Usually, there’s no comma before “if”. Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl... (IF_NO_COMMA) --- [style] ~88-~88: Consider a shorter alternative to avoid wordiness. Context: ...tted Memory* - Memory is over-committed in order to achieve a higher workload density. - ... (IN_ORDER_TO_PREMIUM) --- [style] ~101-~101: Consider a shorter alternative to avoid wordiness. Context: ...given to the compute threads of the VM. In order to ensure this, some additional cores (dep... (IN_ORDER_TO_PREMIUM) --- [style] ~110-~110: Consider a shorter alternative to avoid wordiness. Context: ...are: - *Hugepages* - Hugepages are used in order to improve memory performance. - *Dedica... (IN_ORDER_TO_PREMIUM) --- [style] ~113-~113: Consider a shorter alternative to avoid wordiness. Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante... (IN_ORDER_TO_PREMIUM) --- [style] ~116-~116: Consider a shorter alternative to avoid wordiness. Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the... (IN_ORDER_TO_PREMIUM) --- [style] ~118-~118: Consider a shorter alternative to avoid wordiness. Context: ...NUMA topology is reflected in the guest in order to optimize guest sided cache utilizatio... (IN_ORDER_TO_PREMIUM) --- [style] ~132-~132: Consider a shorter alternative to avoid wordiness. Context: ...are: - *Hugepages* - Hugepages are used in order to improve memory performance. - *Bursta... (IN_ORDER_TO_PREMIUM) --- [typographical] ~135-~135: Usually, there’s no comma before “if”. Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl... (IF_NO_COMMA) --- [style] ~152-~152: Consider a shorter alternative to avoid wordiness. Context: ...are: - *Hugepages* - Hugepages are used in order to improve memory performance. - *Dedica... (IN_ORDER_TO_PREMIUM) --- [style] ~155-~155: Consider a shorter alternative to avoid wordiness. Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante... (IN_ORDER_TO_PREMIUM) --- [style] ~158-~158: Consider a shorter alternative to avoid wordiness. Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the... (IN_ORDER_TO_PREMIUM) </blockquote></details> </blockquote></details> <details> <summary>🪛 Markdownlint</summary><blockquote> <details> <summary>packages/apps/virtual-machine/README.md</summary><blockquote> 19-19: null Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 25-25: null Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 31-31: null Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 52-52: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 53-53: Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 53-53: Expected: 3; Actual: 1; Too few cells, row will be missing data Table column count (MD056, table-column-count) </blockquote></details> </blockquote></details> <details> <summary>🪛 yamllint</summary><blockquote> <details> <summary>packages/apps/virtual-machine/templates/secret.yaml</summary><blockquote> [error] 1-1: syntax error: expected the node content, but found '-' (syntax) --- [error] 9-9: trailing spaces (trailing-spaces) </blockquote></details> <details> <summary>packages/apps/virtual-machine/templates/service.yaml</summary><blockquote> [error] 1-1: syntax error: expected the node content, but found '-' (syntax) </blockquote></details> <details> <summary>packages/apps/virtual-machine/templates/vm.yaml</summary><blockquote> [error] 1-1: syntax error: expected the node content, but found '-' (syntax) </blockquote></details> <details> <summary>packages/apps/virtual-machine/values.yaml</summary><blockquote> [error] 21-21: trailing spaces (trailing-spaces) </blockquote></details> </blockquote></details> </details> <details> <summary>🔇 Additional comments (24)</summary><blockquote> <details> <summary>packages/extra/versions_map (2)</summary><blockquote> `9-9`: **LGTM: Finalized version 1.2.0 of ingress package** The change from 'HEAD' to a specific commit hash (ced8e5b) for ingress version 1.2.0 indicates that this version has been finalized. This is a good practice for version stability and consistency with other package versions in the file. --- `10-10`: **LGTM: New development version 1.3.0 added for ingress package** The addition of version 1.3.0 pointing to 'HEAD' for the ingress package is consistent with the versioning strategy used for other packages in this file. This indicates that 1.3.0 is now the current development version. Please verify that the version increment from 1.2.0 to 1.3.0 accurately reflects the scope of changes in this new version. You can use the following script to check the changes between the two versions: This script will help you confirm that the changes justify a minor version increment (1.2.0 to 1.3.0) rather than a patch version update. </blockquote></details> <details> <summary>packages/apps/virtual-machine/templates/secret.yaml (2)</summary><blockquote> `12-21`: **LGTM! Cloud Init Secret implementation is correct.** The Cloud Init Secret definition is well-implemented: - Conditional rendering is correctly applied. - The Secret naming follows best practices. - The use of `nindent` ensures proper YAML formatting of the cloud-init data. --- `1-21`: **Overall, the Secret definitions are well-implemented.** This file correctly defines two Kubernetes Secrets using Helm templating: 1. SSH Keys Secret 2. Cloud Init Secret Both implementations follow best practices for conditional rendering, naming conventions, and data population. The use of `nindent` for the cloud-init data ensures proper YAML formatting. Note: The syntax error reported by yamllint on line 1 can be ignored as it's a false positive due to Helm templating. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 yamllint</summary><blockquote> [error] 1-1: syntax error: expected the node content, but found '-' (syntax) --- [error] 9-9: trailing spaces (trailing-spaces) </blockquote></details> </details> </blockquote></details> <details> <summary>packages/apps/virtual-machine/templates/service.yaml (3)</summary><blockquote> `1-2`: **LGTM: Conditional inclusion is well-implemented.** The conditional wrapping of the entire Service configuration based on `.Values.external` provides good flexibility in deployment scenarios. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 yamllint</summary><blockquote> [error] 1-1: syntax error: expected the node content, but found '-' (syntax) </blockquote></details> </details> --- `3-8`: **LGTM: Service metadata is well-structured.** The metadata section is correctly defined, using template functions for name and labels, which promotes consistency across resources. --- `1-1`: **False positive: Ignore yamllint syntax error.** The yamllint tool reported a syntax error on this line, but it's a false positive. The `{{- if .Values.external }}` is valid Helm template syntax for a conditional statement with whitespace trimming. yamllint is not aware of Helm template syntax and misinterprets it as YAML syntax. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 yamllint</summary><blockquote> [error] 1-1: syntax error: expected the node content, but found '-' (syntax) </blockquote></details> </details> </blockquote></details> <details> <summary>packages/apps/virtual-machine/Makefile (1)</summary><blockquote> `1-3`: **LGTM: Proper include and target declaration.** The inclusion of the common package.mk file and the declaration of the `generate` target are well-structured and follow good Makefile practices. </blockquote></details> <details> <summary>packages/apps/virtual-machine/Chart.yaml (3)</summary><blockquote> `7-15`: **LGTM: Chart type is correctly set.** The chart type is appropriately set to "application", which is correct for a deployable virtual machine chart. The included comments provide valuable context for maintainers and contributors. --- `20-20`: **Confirm initial chart version.** The chart version is set to 0.5.0, which suggests that this chart is not yet considered production-ready. Please confirm if this is the intended initial version for this new chart. --- `26-26`: **Verify application version.** The application version is set to "1.16.1", which seems relatively high compared to the chart version (0.5.0). Please confirm: 1. Is this the correct version of the application being deployed? 2. If so, consider adding a comment explaining why the application version is higher than the chart version (e.g., "This chart is new, but it deploys a pre-existing application"). </blockquote></details> <details> <summary>packages/apps/virtual-machine/templates/_helpers.tpl (6)</summary><blockquote> `4-6`: **LGTM: Proper implementation of chart name expansion** The `virtual-machine.name` template correctly implements chart name expansion following Helm best practices. It appropriately handles name overrides, truncation to 63 characters (adhering to Kubernetes naming conventions), and removal of trailing hyphens. --- `13-24`: **LGTM: Comprehensive implementation of fully qualified app name** The `virtual-machine.fullname` template demonstrates a thorough approach to generating a fully qualified application name. It correctly handles fullname overrides, cases where the release name contains the chart name, and fallback scenarios. The consistent application of the 63-character limit ensures compatibility with Kubernetes naming restrictions. --- `29-31`: **LGTM: Correct implementation of chart name and version string** The `virtual-machine.chart` template correctly generates a chart name and version string. It appropriately replaces '+' with '_' to ensure compatibility with Kubernetes label value restrictions, applies the 63-character limit, and removes trailing hyphens. This implementation adheres to Helm best practices for chart labeling. --- `36-43`: **LGTM: Well-structured common labels template** The `virtual-machine.labels` template provides a comprehensive set of common labels for Kubernetes resources. It correctly includes recommended labels such as `helm.sh/chart` and `app.kubernetes.io/managed-by`, and appropriately handles the conditional inclusion of `app.kubernetes.io/version`. This implementation aligns with Kubernetes best practices for resource labeling. --- `48-51`: **LGTM: Appropriate implementation of selector labels** The `virtual-machine.selectorLabels` template correctly generates the essential selector labels for the application instance. It includes both the app name and release instance, following Kubernetes best practices. The use of the `virtual-machine.name` template ensures consistency with other naming conventions in the chart. --- `1-51`: **Excellent implementation of Helm chart helper templates** This file demonstrates a comprehensive and well-structured set of Helm chart helper templates for the virtual-machine application. All five templates (`name`, `fullname`, `chart`, `labels`, and `selectorLabels`) are implemented following Helm and Kubernetes best practices. They provide a consistent and robust naming and labeling strategy that will contribute to the maintainability and clarity of the Kubernetes resources generated by this chart. Key strengths: 1. Consistent application of the 63-character limit for Kubernetes naming conventions. 2. Proper handling of override scenarios in name generation. 3. Comprehensive labeling strategy that includes all recommended Kubernetes labels. 4. Consistent use of templating to ensure naming coherence across resources. Overall, this is a high-quality implementation that sets a strong foundation for the virtual-machine Helm chart. </blockquote></details> <details> <summary>packages/apps/virtual-machine/templates/vm.yaml (3)</summary><blockquote> `1-6`: **LGTM: Effective validation of instanceType and instanceProfile.** The validation checks for the existence of the specified instanceType and instanceProfile in the cluster before proceeding. This is a crucial step to prevent runtime errors and provides clear error messages for troubleshooting. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 yamllint</summary><blockquote> [error] 1-1: syntax error: expected the node content, but found '-' (syntax) </blockquote></details> </details> --- `8-13`: **LGTM: Well-structured metadata section.** The metadata section is correctly defined with appropriate apiVersion and kind for a KubeVirt VirtualMachine. The use of template functions for name and labels promotes consistency and reusability across deployments. --- `1-102`: **Overall, well-structured and comprehensive VM template.** This template provides a solid foundation for creating virtual machines using KubeVirt. It includes essential features such as instance type validation, flexible storage configuration, and support for SSH keys and cloud-init. The suggested improvements for configurability (default running state, volume modes, termination grace period, and multiple network interfaces) will enhance its versatility without compromising current functionality. Great job on creating this template! With the proposed enhancements, it will be even more adaptable to various use cases. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 yamllint</summary><blockquote> [error] 1-1: syntax error: expected the node content, but found '-' (syntax) </blockquote></details> </details> </blockquote></details> <details> <summary>packages/apps/virtual-machine/values.schema.json (2)</summary><blockquote> `1-4`: **LGTM: Schema structure is well-defined.** The schema is correctly structured as an object with a clear title "Chart Values". This provides a good foundation for defining the configuration options for a virtual machine. --- `174-178`: **LGTM: 'cloudInit' property is well-defined.** The 'cloudInit' property is correctly structured with an appropriate default value for cloud-init configuration. This provides a good starting point for users to customize their virtual machine initialization. </blockquote></details> <details> <summary>packages/apps/virtual-machine/README.md (2)</summary><blockquote> `55-161`: **LGTM! Comprehensive instance type descriptions** The Instance Type Series section provides detailed and well-organized information about the different series (U, O, CX, M, RT). Each series is clearly described with its specific characteristics and use cases. This information will be very helpful for users in choosing the appropriate instance type for their needs. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 LanguageTool</summary><blockquote> [typographical] ~70-~70: Usually, there’s no comma before “if”. Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl... (IF_NO_COMMA) --- [typographical] ~86-~86: Usually, there’s no comma before “if”. Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl... (IF_NO_COMMA) --- [style] ~88-~88: Consider a shorter alternative to avoid wordiness. Context: ...tted Memory* - Memory is over-committed in order to achieve a higher workload density. - ... (IN_ORDER_TO_PREMIUM) --- [style] ~101-~101: Consider a shorter alternative to avoid wordiness. Context: ...given to the compute threads of the VM. In order to ensure this, some additional cores (dep... (IN_ORDER_TO_PREMIUM) --- [style] ~110-~110: Consider a shorter alternative to avoid wordiness. Context: ...are: - *Hugepages* - Hugepages are used in order to improve memory performance. - *Dedica... (IN_ORDER_TO_PREMIUM) --- [style] ~113-~113: Consider a shorter alternative to avoid wordiness. Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante... (IN_ORDER_TO_PREMIUM) --- [style] ~116-~116: Consider a shorter alternative to avoid wordiness. Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the... (IN_ORDER_TO_PREMIUM) --- [style] ~118-~118: Consider a shorter alternative to avoid wordiness. Context: ...NUMA topology is reflected in the guest in order to optimize guest sided cache utilizatio... (IN_ORDER_TO_PREMIUM) --- [style] ~132-~132: Consider a shorter alternative to avoid wordiness. Context: ...are: - *Hugepages* - Hugepages are used in order to improve memory performance. - *Bursta... (IN_ORDER_TO_PREMIUM) --- [typographical] ~135-~135: Usually, there’s no comma before “if”. Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl... (IF_NO_COMMA) --- [style] ~152-~152: Consider a shorter alternative to avoid wordiness. Context: ...are: - *Hugepages* - Hugepages are used in order to improve memory performance. - *Dedica... (IN_ORDER_TO_PREMIUM) --- [style] ~155-~155: Consider a shorter alternative to avoid wordiness. Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante... (IN_ORDER_TO_PREMIUM) --- [style] ~158-~158: Consider a shorter alternative to avoid wordiness. Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the... (IN_ORDER_TO_PREMIUM) </blockquote></details> </details> --- `1-268`: **Overall, a well-written and informative README with minor improvements needed** This README file provides comprehensive and valuable information about the Virtual Machine project. It covers all essential aspects, including an introduction, deployment details, access methods, parameters, instance types, and available resources. The content is well-organized and will be very helpful for users and developers working with this project. To further enhance the document, please address the following main points: 1. Fix table formatting issues throughout the document to ensure proper rendering. 2. Add language specifications to code blocks for improved readability. 3. Verify the existence of the referenced DEVELOPMENT.md file. 4. Consider adding brief headers to the resource tables for better organization. Once these improvements are made, the README will be an excellent resource for the Virtual Machine project. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 LanguageTool</summary><blockquote> [style] ~51-~51: To form a complete sentence, be sure to include a subject or ‘there’. Context: ... of SSH public keys for authentication. Can be a single key or a list of keys. | `[... (MISSING_IT_THERE) --- [typographical] ~70-~70: Usually, there’s no comma before “if”. Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl... (IF_NO_COMMA) --- [typographical] ~86-~86: Usually, there’s no comma before “if”. Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl... (IF_NO_COMMA) --- [style] ~88-~88: Consider a shorter alternative to avoid wordiness. Context: ...tted Memory* - Memory is over-committed in order to achieve a higher workload density. - ... (IN_ORDER_TO_PREMIUM) --- [style] ~101-~101: Consider a shorter alternative to avoid wordiness. Context: ...given to the compute threads of the VM. In order to ensure this, some additional cores (dep... (IN_ORDER_TO_PREMIUM) --- [style] ~110-~110: Consider a shorter alternative to avoid wordiness. Context: ...are: - *Hugepages* - Hugepages are used in order to improve memory performance. - *Dedica... (IN_ORDER_TO_PREMIUM) --- [style] ~113-~113: Consider a shorter alternative to avoid wordiness. Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante... (IN_ORDER_TO_PREMIUM) --- [style] ~116-~116: Consider a shorter alternative to avoid wordiness. Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the... (IN_ORDER_TO_PREMIUM) --- [style] ~118-~118: Consider a shorter alternative to avoid wordiness. Context: ...NUMA topology is reflected in the guest in order to optimize guest sided cache utilizatio... (IN_ORDER_TO_PREMIUM) --- [style] ~132-~132: Consider a shorter alternative to avoid wordiness. Context: ...are: - *Hugepages* - Hugepages are used in order to improve memory performance. - *Bursta... (IN_ORDER_TO_PREMIUM) --- [typographical] ~135-~135: Usually, there’s no comma before “if”. Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl... (IF_NO_COMMA) --- [style] ~152-~152: Consider a shorter alternative to avoid wordiness. Context: ...are: - *Hugepages* - Hugepages are used in order to improve memory performance. - *Dedica... (IN_ORDER_TO_PREMIUM) --- [style] ~155-~155: Consider a shorter alternative to avoid wordiness. Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante... (IN_ORDER_TO_PREMIUM) --- [style] ~158-~158: Consider a shorter alternative to avoid wordiness. Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the... (IN_ORDER_TO_PREMIUM) </blockquote></details> <details> <summary>🪛 Markdownlint</summary><blockquote> 19-19: null Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 25-25: null Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 31-31: null Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 52-52: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 53-53: Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe Table pipe style (MD055, table-pipe-style) --- 268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe Table pipe style (MD055, table-pipe-style) --- 53-53: Expected: 3; Actual: 1; Too few cells, row will be missing data Table column count (MD056, table-column-count) </blockquote></details> </details> </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
| ingress 1.2.0 ced8e5b | ||
| ingress 1.3.0 HEAD |
There was a problem hiding this comment.
💡 Codebase verification
Unrelated Changes Detected in PR
The PR includes updates to the ingress package versions in packages/extra/versions_map, which are unrelated to the primary objective of adding a virtual machine. Please ensure that the PR focuses solely on the virtual machine addition or separate unrelated changes into different PRs.
🔗 Analysis chain
Clarification needed: Changes unrelated to PR title
The changes in this file are focused on updating the ingress package versions. However, the PR title mentions "Add Virtual Machine (simple)". There appear to be no changes related to adding a virtual machine in this file.
Could you please clarify if there are additional files in this PR that address the virtual machine addition mentioned in the title? If not, consider updating the PR title to accurately reflect the changes made.
To help verify this, you can run the following script to check for any virtual machine related changes in the PR:
This script will list all changed files in the PR and search for any mentions of "virtual machine" in the changes. Please review the output to ensure all intended changes are present.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for virtual machine related changes in the PR
# Fetch the latest changes
git fetch origin
# Get the base branch of the PR
base_branch=$(gh pr view 430 --json baseRefName --jq .baseRefName)
# Show files changed in the PR
echo "Files changed in PR #430:"
git diff --name-only $base_branch...HEAD
# Search for virtual machine related changes
echo -e "\nSearching for virtual machine related changes:"
git diff $base_branch...HEAD | grep -i "virtual.*machine"
Length of output: 6800
| #name: Virtual Machine | ||
| name: virtual-machine | ||
| description: Virtual Machine (simple) | ||
| icon: /logos/vm.svg |
There was a problem hiding this comment.
💡 Codebase verification
Update the icon path to a relative location.
The absolute path /logos/vm.svg does not exist. Consider using a relative path such as logos/vm.svg within the chart's directory.
🔗 Analysis chain
Verify the icon path.
The icon path /logos/vm.svg is specified as an absolute path. Ensure that this path is correct relative to the chart's root or consider using a relative path if the icon is stored within the chart's directory structure.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of the icon file
# Test: Check if the icon file exists
if fd -p "/logos/vm.svg" ; then
echo "Icon file found"
else
echo "Icon file not found at the specified path"
echo "Searching for similar files:"
fd -e svg
fi
Length of output: 144
| ## @param systemDisk.origin The HTTP URL for source image | ||
| ## @param systemDisk.storage The size of the disk allocated for the virtual machine | ||
| ## @param systemDisk.storageClass StorageClass used to store the data | ||
| ## | ||
| systemDisk: | ||
| origin: "" | ||
| storage: 5Gi | ||
| storageClass: replicated |
There was a problem hiding this comment.
Address empty origin and improve documentation.
The system disk configuration looks good overall, but there are a few points to address:
-
The
originparameter is empty. Please provide a default value or clear instructions on how to set it. -
Consider adding comments or documentation links explaining the available
storageClassoptions and their implications. -
Remove the trailing space on line 21 to fix the linting error.
Here's a suggested fix for the trailing space:
## @param systemDisk.origin The HTTP URL for source image
## @param systemDisk.storage The size of the disk allocated for the virtual machine
## @param systemDisk.storageClass StorageClass used to store the data
-##
+##
systemDisk:
origin: ""
storage: 5Gi
storageClass: replicated📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## @param systemDisk.origin The HTTP URL for source image | |
| ## @param systemDisk.storage The size of the disk allocated for the virtual machine | |
| ## @param systemDisk.storageClass StorageClass used to store the data | |
| ## | |
| systemDisk: | |
| origin: "" | |
| storage: 5Gi | |
| storageClass: replicated | |
| ## @param systemDisk.origin The HTTP URL for source image | |
| ## @param systemDisk.storage The size of the disk allocated for the virtual machine | |
| ## @param systemDisk.storageClass StorageClass used to store the data | |
| ## | |
| systemDisk: | |
| origin: "" | |
| storage: 5Gi | |
| storageClass: replicated |
🧰 Tools
🪛 yamllint
[error] 21-21: trailing spaces
(trailing-spaces)
| dataVolumeTemplates: | ||
| - metadata: | ||
| name: {{ include "virtual-machine.fullname" . }} | ||
| spec: | ||
| pvc: | ||
| volumeMode: Block | ||
| accessModes: | ||
| - ReadWriteMany | ||
| resources: | ||
| requests: | ||
| storage: {{ $.Values.systemDisk.storage | quote }} | ||
| {{- with $.Values.systemDisk.storageClass }} | ||
| storageClassName: {{ . }} | ||
| {{- end }} | ||
| source: | ||
| {{- if $.Values.systemDisk.origin }} | ||
| http: | ||
| url: {{ $.Values.systemDisk.origin }} | ||
| {{- else }} | ||
| blank: {} | ||
| {{- end }} |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider making volumeMode and accessModes configurable.
The dataVolumeTemplates section is well-structured and provides flexibility for storage configuration. However, the hardcoded volumeMode (Block) and accessModes (ReadWriteMany) might not be suitable for all storage backends.
Consider modifying the PVC specification to allow for configurable volumeMode and accessModes:
pvc:
- volumeMode: Block
+ volumeMode: {{ .Values.systemDisk.volumeMode | default "Block" }}
accessModes:
- - ReadWriteMany
+ {{ .Values.systemDisk.accessModes | default (list "ReadWriteMany") | toYaml | nindent 8 }}This change would allow users to specify different volumeMode and accessModes in their values file, while maintaining the current defaults if not specified.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| dataVolumeTemplates: | |
| - metadata: | |
| name: {{ include "virtual-machine.fullname" . }} | |
| spec: | |
| pvc: | |
| volumeMode: Block | |
| accessModes: | |
| - ReadWriteMany | |
| resources: | |
| requests: | |
| storage: {{ $.Values.systemDisk.storage | quote }} | |
| {{- with $.Values.systemDisk.storageClass }} | |
| storageClassName: {{ . }} | |
| {{- end }} | |
| source: | |
| {{- if $.Values.systemDisk.origin }} | |
| http: | |
| url: {{ $.Values.systemDisk.origin }} | |
| {{- else }} | |
| blank: {} | |
| {{- end }} | |
| dataVolumeTemplates: | |
| - metadata: | |
| name: {{ include "virtual-machine.fullname" . }} | |
| spec: | |
| pvc: | |
| volumeMode: {{ .Values.systemDisk.volumeMode | default "Block" }} | |
| accessModes: | |
| {{ .Values.systemDisk.accessModes | default (list "ReadWriteMany") | toYaml | nindent 8 }} | |
| resources: | |
| requests: | |
| storage: {{ $.Values.systemDisk.storage | quote }} | |
| {{- with $.Values.systemDisk.storageClass }} | |
| storageClassName: {{ . }} | |
| {{- end }} | |
| source: | |
| {{- if $.Values.systemDisk.origin }} | |
| http: | |
| url: {{ $.Values.systemDisk.origin }} | |
| {{- else }} | |
| blank: {} | |
| {{- end }} |
| "cx1.8xlarge", | ||
| "cx1.large", | ||
| "cx1.medium", | ||
| "cx1.xlarge", | ||
| "gn1.2xlarge", | ||
| "gn1.4xlarge", | ||
| "gn1.8xlarge", | ||
| "gn1.xlarge", | ||
| "m1.2xlarge", | ||
| "m1.4xlarge", | ||
| "m1.8xlarge", | ||
| "m1.large", | ||
| "m1.xlarge", | ||
| "n1.2xlarge", | ||
| "n1.4xlarge", | ||
| "n1.8xlarge", | ||
| "n1.large", | ||
| "n1.medium", | ||
| "n1.xlarge", | ||
| "o1.2xlarge", | ||
| "o1.4xlarge", | ||
| "o1.8xlarge", | ||
| "o1.large", | ||
| "o1.medium", | ||
| "o1.micro", | ||
| "o1.nano", | ||
| "o1.small", | ||
| "o1.xlarge", | ||
| "rt1.2xlarge", | ||
| "rt1.4xlarge", | ||
| "rt1.8xlarge", | ||
| "rt1.large", | ||
| "rt1.medium", | ||
| "rt1.micro", | ||
| "rt1.small", | ||
| "rt1.xlarge", | ||
| "u1.2xlarge", | ||
| "u1.2xmedium", | ||
| "u1.4xlarge", | ||
| "u1.8xlarge", | ||
| "u1.large", | ||
| "u1.medium", | ||
| "u1.micro", | ||
| "u1.nano", | ||
| "u1.small", | ||
| "u1.xlarge", | ||
| "" | ||
| ] | ||
| }, | ||
| "instanceProfile": { | ||
| "type": "string", | ||
| "description": "Virtual Machine prefferences profile", | ||
| "default": "ubuntu", | ||
| "optional": true, | ||
| "enum": [ | ||
| "alpine", | ||
| "centos.7", | ||
| "centos.7.desktop", | ||
| "centos.stream10", | ||
| "centos.stream10.desktop", | ||
| "centos.stream8", | ||
| "centos.stream8.desktop", | ||
| "centos.stream8.dpdk", | ||
| "centos.stream9", | ||
| "centos.stream9.desktop", | ||
| "centos.stream9.dpdk", | ||
| "cirros", | ||
| "fedora", | ||
| "fedora.arm64", | ||
| "opensuse.leap", | ||
| "opensuse.tumbleweed", | ||
| "rhel.10", | ||
| "rhel.10.arm64", | ||
| "rhel.7", | ||
| "rhel.7.desktop", | ||
| "rhel.8", | ||
| "rhel.8.desktop", | ||
| "rhel.8.dpdk", | ||
| "rhel.9", | ||
| "rhel.9.arm64", | ||
| "rhel.9.desktop", | ||
| "rhel.9.dpdk", | ||
| "rhel.9.realtime", | ||
| "sles", | ||
| "ubuntu", | ||
| "windows.10", | ||
| "windows.10.virtio", | ||
| "windows.11", | ||
| "windows.11.virtio", | ||
| "windows.2k16", | ||
| "windows.2k16.virtio", | ||
| "windows.2k19", | ||
| "windows.2k19.virtio", | ||
| "windows.2k22", | ||
| "windows.2k22.virtio", | ||
| "windows.2k25", | ||
| "windows.2k25.virtio", | ||
| "" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Improve schema definition for 'instanceType' and 'instanceProfile'.
The 'running', 'instanceType', and 'instanceProfile' properties are generally well-defined, but there are a few improvements we can make:
- The 'optional' field is not a standard JSON Schema keyword. Instead, you can use 'required' at the parent object level to specify which fields are mandatory.
- An empty string is included in the enum for both 'instanceType' and 'instanceProfile'. This might lead to unexpected behavior.
Please consider the following changes:
- Remove the 'optional' field from 'instanceType' and 'instanceProfile'.
- Remove the empty string from the enum lists of 'instanceType' and 'instanceProfile'.
- If you want to make these fields optional, add a 'required' array at the root level of the schema listing all mandatory fields.
Example:
- "optional": true,
"enum": [
// ... other values ...
- ""
]Add at the root level of the schema:
"required": ["running", "systemDisk", "resources"]This assumes that 'running', 'systemDisk', and 'resources' are mandatory, while other fields are optional. Adjust the list as needed based on your requirements.
| "resources": { | ||
| "type": "object", | ||
| "properties": { | ||
| "cpu": { | ||
| "type": "string", | ||
| "description": "The number of CPU cores allocated to the virtual machine", | ||
| "default": "" | ||
| }, | ||
| "memory": { | ||
| "type": "string", | ||
| "description": "The amount of memory allocated to the virtual machine", | ||
| "default": "" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Improve 'resources' property definition.
The 'resources' property structure is appropriate, but the default values for 'cpu' and 'memory' need attention.
Both 'cpu' and 'memory' have empty strings as default values. This might lead to unexpected behavior when deploying the virtual machine.
Consider the following suggestions:
- Remove the default values entirely, making these fields required.
- Provide meaningful default values that align with the most common use case.
Example change:
"cpu": {
"type": "string",
"description": "The number of CPU cores allocated to the virtual machine",
- "default": ""
},
"memory": {
"type": "string",
"description": "The amount of memory allocated to the virtual machine",
- "default": ""
}If you choose to make these fields required, add them to a 'required' array within the 'resources' object:
"resources": {
"type": "object",
"required": ["cpu", "memory"],
"properties": {
// ... existing properties ...
}
}This ensures that valid CPU and memory values are always provided.
| "sshKeys": { | ||
| "type": "array", | ||
| "description": "List of SSH public keys for authentication. Can be a single key or a list of keys.", | ||
| "default": "[]", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Fix the default value for 'sshKeys'.
The 'sshKeys' property is well-defined, but there's a minor issue with its default value.
Similar to the 'externalPorts' property, the default value for 'sshKeys' is defined as a string "[]" instead of an actual empty array.
Please update it as follows:
- "default": "[]",
+ "default": [],This change ensures that the default value is a valid JSON array.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "sshKeys": { | |
| "type": "array", | |
| "description": "List of SSH public keys for authentication. Can be a single key or a list of keys.", | |
| "default": "[]", | |
| "items": { | |
| "type": "string" | |
| } | |
| }, | |
| "sshKeys": { | |
| "type": "array", | |
| "description": "List of SSH public keys for authentication. Can be a single key or a list of keys.", | |
| "default": [], | |
| "items": { | |
| "type": "string" | |
| } | |
| }, |
| "external": { | ||
| "type": "boolean", | ||
| "description": "Enable external access from outside the cluster", | ||
| "default": false | ||
| }, | ||
| "externalPorts": { | ||
| "type": "array", | ||
| "description": "Specify ports to forward from outside the cluster", | ||
| "default": "[]", | ||
| "items": { | ||
| "type": "integer" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Fix the default value for 'externalPorts'.
The 'external' and 'externalPorts' properties are well-defined. However, there's a minor issue with the 'externalPorts' default value.
The default value for 'externalPorts' is defined as a string "[]" instead of an actual empty array. Please update it as follows:
- "default": "[]",
+ "default": [],This change ensures that the default value is a valid JSON array.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "external": { | |
| "type": "boolean", | |
| "description": "Enable external access from outside the cluster", | |
| "default": false | |
| }, | |
| "externalPorts": { | |
| "type": "array", | |
| "description": "Specify ports to forward from outside the cluster", | |
| "default": "[]", | |
| "items": { | |
| "type": "integer" | |
| } | |
| }, | |
| "external": { | |
| "type": "boolean", | |
| "description": "Enable external access from outside the cluster", | |
| "default": false | |
| }, | |
| "externalPorts": { | |
| "type": "array", | |
| "description": "Specify ports to forward from outside the cluster", | |
| "default": [], | |
| "items": { | |
| "type": "integer" | |
| } | |
| }, |
| ## Parameters | ||
|
|
||
| ### Common parameters | ||
|
|
||
| | Name | Description | Value | | ||
| | ------------------------- | ---------------------------------------------------------------------------------- | ---------------- | | ||
| | `external` | Enable external access from outside the cluster | `false` | | ||
| | `externalPorts` | Specify ports to forward from outside the cluster | `[]` | | ||
| | `running` | Determines if the virtual machine should be running | `true` | | ||
| | `instanceType` | Virtual Machine instance type | `u1.medium` | | ||
| | `instanceProfile` | Virtual Machine prefferences profile | `ubuntu` | | ||
| | `systemDisk.origin` | The HTTP URL for source image | `""` | | ||
| | `systemDisk.storage` | The size of the disk allocated for the virtual machine | `5Gi` | | ||
| | `systemDisk.storageClass` | StorageClass used to store the data | `replicated` | | ||
| | `resources.cpu` | The number of CPU cores allocated to the virtual machine | `""` | | ||
| | `resources.memory` | The amount of memory allocated to the virtual machine | `""` | | ||
| | `sshKeys` | List of SSH public keys for authentication. Can be a single key or a list of keys. | `[]` | | ||
| | `cloudInit` | cloud-init user data config. See cloud-init documentation for more details. | `#cloud-config | ||
| ` | |
There was a problem hiding this comment.
Fix table formatting for better rendering
The Parameters section provides valuable information about common configuration options. However, the table formatting needs to be adjusted to ensure proper rendering in Markdown. Please apply the following changes:
- Add leading and trailing pipes to each row.
- Ensure the separator row (line 40) has the correct number of cells.
- Add a trailing pipe to the last cell of each row.
Here's an example of how the corrected table header and separator should look:
| Name | Description | Value |
|------|-------------|-------|Apply this format to the entire table to improve its rendering and readability.
🧰 Tools
🪛 LanguageTool
[style] ~51-~51: To form a complete sentence, be sure to include a subject or ‘there’.
Context: ... of SSH public keys for authentication. Can be a single key or a list of keys. | `[...(MISSING_IT_THERE)
🪛 Markdownlint
52-52: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
53-53: Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
53-53: Expected: 3; Actual: 1; Too few cells, row will be missing data
Table column count(MD056, table-column-count)
|
|
||
| The following instancetype resources are provided by Cozystack: | ||
|
|
||
| Name | vCPUs | Memory | ||
| -----|-------|------- | ||
| cx1.2xlarge | 8 | 16Gi | ||
| cx1.4xlarge | 16 | 32Gi | ||
| cx1.8xlarge | 32 | 64Gi | ||
| cx1.large | 2 | 4Gi | ||
| cx1.medium | 1 | 2Gi | ||
| cx1.xlarge | 4 | 8Gi | ||
| gn1.2xlarge | 8 | 32Gi | ||
| gn1.4xlarge | 16 | 64Gi | ||
| gn1.8xlarge | 32 | 128Gi | ||
| gn1.xlarge | 4 | 16Gi | ||
| m1.2xlarge | 8 | 64Gi | ||
| m1.4xlarge | 16 | 128Gi | ||
| m1.8xlarge | 32 | 256Gi | ||
| m1.large | 2 | 16Gi | ||
| m1.xlarge | 4 | 32Gi | ||
| n1.2xlarge | 16 | 32Gi | ||
| n1.4xlarge | 32 | 64Gi | ||
| n1.8xlarge | 64 | 128Gi | ||
| n1.large | 4 | 8Gi | ||
| n1.medium | 4 | 4Gi | ||
| n1.xlarge | 8 | 16Gi | ||
| o1.2xlarge | 8 | 32Gi | ||
| o1.4xlarge | 16 | 64Gi | ||
| o1.8xlarge | 32 | 128Gi | ||
| o1.large | 2 | 8Gi | ||
| o1.medium | 1 | 4Gi | ||
| o1.micro | 1 | 1Gi | ||
| o1.nano | 1 | 512Mi | ||
| o1.small | 1 | 2Gi | ||
| o1.xlarge | 4 | 16Gi | ||
| rt1.2xlarge | 8 | 32Gi | ||
| rt1.4xlarge | 16 | 64Gi | ||
| rt1.8xlarge | 32 | 128Gi | ||
| rt1.large | 2 | 8Gi | ||
| rt1.medium | 1 | 4Gi | ||
| rt1.micro | 1 | 1Gi | ||
| rt1.small | 1 | 2Gi | ||
| rt1.xlarge | 4 | 16Gi | ||
| u1.2xlarge | 8 | 32Gi | ||
| u1.2xmedium | 2 | 4Gi | ||
| u1.4xlarge | 16 | 64Gi | ||
| u1.8xlarge | 32 | 128Gi | ||
| u1.large | 2 | 8Gi | ||
| u1.medium | 1 | 4Gi | ||
| u1.micro | 1 | 1Gi | ||
| u1.nano | 1 | 512Mi | ||
| u1.small | 1 | 2Gi | ||
| u1.xlarge | 4 | 16Gi | ||
|
|
||
| The following preference resources are provided by Cozystack: | ||
|
|
||
| Name | Guest OS | ||
| -----|--------- | ||
| alpine | Alpine | ||
| centos.7 | CentOS 7 | ||
| centos.7.desktop | CentOS 7 | ||
| centos.stream10 | CentOS Stream 10 | ||
| centos.stream10.desktop | CentOS Stream 10 | ||
| centos.stream8 | CentOS Stream 8 | ||
| centos.stream8.desktop | CentOS Stream 8 | ||
| centos.stream8.dpdk | CentOS Stream 8 | ||
| centos.stream9 | CentOS Stream 9 | ||
| centos.stream9.desktop | CentOS Stream 9 | ||
| centos.stream9.dpdk | CentOS Stream 9 | ||
| cirros | Cirros | ||
| fedora | Fedora (amd64) | ||
| fedora.arm64 | Fedora (arm64) | ||
| opensuse.leap | OpenSUSE Leap | ||
| opensuse.tumbleweed | OpenSUSE Tumbleweed | ||
| rhel.10 | Red Hat Enterprise Linux 10 Beta (amd64) | ||
| rhel.10.arm64 | Red Hat Enterprise Linux 10 Beta (arm64) | ||
| rhel.7 | Red Hat Enterprise Linux 7 | ||
| rhel.7.desktop | Red Hat Enterprise Linux 7 | ||
| rhel.8 | Red Hat Enterprise Linux 8 | ||
| rhel.8.desktop | Red Hat Enterprise Linux 8 | ||
| rhel.8.dpdk | Red Hat Enterprise Linux 8 | ||
| rhel.9 | Red Hat Enterprise Linux 9 (amd64) | ||
| rhel.9.arm64 | Red Hat Enterprise Linux 9 (arm64) | ||
| rhel.9.desktop | Red Hat Enterprise Linux 9 Desktop (amd64) | ||
| rhel.9.dpdk | Red Hat Enterprise Linux 9 DPDK (amd64) | ||
| rhel.9.realtime | Red Hat Enterprise Linux 9 Realtime (amd64) | ||
| sles | SUSE Linux Enterprise Server | ||
| ubuntu | Ubuntu | ||
| windows.10 | Microsoft Windows 10 | ||
| windows.10.virtio | Microsoft Windows 10 (virtio) | ||
| windows.11 | Microsoft Windows 11 | ||
| windows.11.virtio | Microsoft Windows 11 (virtio) | ||
| windows.2k16 | Microsoft Windows Server 2016 | ||
| windows.2k16.virtio | Microsoft Windows Server 2016 (virtio) | ||
| windows.2k19 | Microsoft Windows Server 2019 | ||
| windows.2k19.virtio | Microsoft Windows Server 2019 (virtio) | ||
| windows.2k22 | Microsoft Windows Server 2022 | ||
| windows.2k22.virtio | Microsoft Windows Server 2022 (virtio) | ||
| windows.2k25 | Microsoft Windows Server 2025 | ||
| windows.2k25.virtio | Microsoft Windows Server 2025 (virtio) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve table formatting and consider adding headers
The Resource Tables section provides comprehensive information about instancetype resources and preference resources. However, there are formatting issues that need to be addressed:
- Add leading and trailing pipes to each row in both tables.
- Ensure the separator row has the correct number of cells and is properly formatted.
Additionally, consider adding headers to both tables to improve clarity. For example:
## Instancetype Resources
| Name | vCPUs | Memory |
|------|-------|--------|
| cx1.2xlarge | 8 | 16Gi |
...
## Preference Resources
| Name | Guest OS |
|------|----------|
| alpine | Alpine |
...These changes will significantly improve the readability and structure of the resource information.
🧰 Tools
🪛 Markdownlint
172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
Signed-off-by: Andrei Kvapil <[email protected]>
kvaps
force-pushed
the
virtual-machine-simple
branch
from
3841821 to
b59d283
Compare
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Outside diff range and nitpick comments (13)
packages/apps/virtual-machine/templates/secret.yaml (2)
1-11: LGTM with a minor formatting suggestion.The SSH Keys Secret implementation looks good overall. It's conditionally rendered, uses appropriate naming conventions, and correctly populates the Secret data.
However, there's a minor formatting issue:
Remove the trailing space on line 9:
- key{{ $k }}: {{ quote $v }} + key{{ $k }}: {{ quote $v }}This change will improve code cleanliness and adhere to YAML best practices.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
[error] 9-9: trailing spaces
(trailing-spaces)
1-21: Overall, excellent implementation of Secrets for Virtual Machine resources.This file successfully implements two conditional Secrets that are crucial for Virtual Machine management:
- SSH Keys Secret: Stores SSH keys for secure access to VMs.
- Cloud Init Secret: Stores cloud-init userdata for VM initialization.
The use of Helm templating is appropriate, allowing for flexible configuration through
.Values. The conditional rendering ensures that Secrets are only created when necessary, following the principle of least privilege.Consider adding metadata labels to both Secrets (e.g.,
app.kubernetes.io/name,app.kubernetes.io/instance) for better resource management and potential use in network policies or RBAC rules.🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
[error] 9-9: trailing spaces
(trailing-spaces)
packages/apps/virtual-machine/templates/service.yaml (2)
9-14: LGTM: Service specification is well-configured with a minor suggestion.The dynamic Service type, Local external traffic policy, and disabled node port allocation are all good practices. The selector correctly matches the metadata labels.
Consider using a separate template function for selector labels to allow for more granular control:
selector: {{- include "virtual-machine.selectorLabels" . | nindent 4 }}This would require defining a new template function
virtual-machine.selectorLabelsin your_helpers.tplfile.
15-20: LGTM: Port configuration is flexible, with room for minor enhancements.The dynamic port generation from
.Values.externalPortsprovides good flexibility. The naming convention for ports is clear and consistent.Consider the following enhancements:
Allow for different port and targetPort values:
{{- range $port := .Values.externalPorts }} - name: port-{{ $port.name | default $port.port }} port: {{ $port.port }} targetPort: {{ $port.targetPort | default $port.port }} {{- if $port.protocol }} protocol: {{ $port.protocol }} {{- end }} {{- end }}Add a protocol field to allow specifying UDP ports if needed.
These changes would require updating the structure of
.Values.externalPortsin yourvalues.yamlfile.packages/apps/virtual-machine/values.yaml (3)
9-16: LGTM: VM state and instance configuration is well-defined.The configuration for the VM running state and instance type is clear and well-documented. Default values are provided, which is good for ease of use.
Consider adding a comment or documentation link explaining the available
instanceTypeoptions (e.g., "u1.medium") and their specifications, as these might be specific to your environment or cloud provider.
18-25: LGTM: System disk configuration is well-defined.The system disk configuration is clear, well-documented, and provides sensible default values.
There's a minor formatting issue: remove the trailing space on line 21 to address the linting error. Here's the fix:
## @param systemDisk.image The base image for the virtual machine. Allowed values: `ubuntu`, `cirros`, `alpine`, `fedora` and `talos` ## @param systemDisk.storage The size of the disk allocated for the virtual machine ## @param systemDisk.storageClass StorageClass used to store the data -## +## systemDisk: image: ubuntu storage: 5Gi storageClass: replicated🧰 Tools
🪛 yamllint
[error] 21-21: trailing spaces
(trailing-spaces)
41-51: LGTM: Cloud-init configuration is well-documented and flexible.The cloud-init configuration is clear, well-documented, and provides helpful links and examples. The provided default cloud-config serves as a good starting point.
Consider adding a comment recommending users to avoid storing sensitive information (like passwords) directly in the cloud-init configuration, especially in production environments. Instead, suggest using secure methods like environment variables or external secret management systems.
packages/apps/virtual-machine/templates/vm.yaml (3)
1-6: Excellent input validation, consider enhancing error handling.The validation of
instanceTypeandinstanceProfileis a great practice. It ensures that the required resources exist in the cluster before attempting to create the VirtualMachine.Consider wrapping the error messages in quotes to improve readability in case of spaces or special characters:
{{- fail (printf "Specified instancetype not exists in cluster: '%s'" .Values.instanceType) }} {{- fail (printf "Specified profile not exists in cluster: '%s'" .Values.instanceProfile) }}🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
26-53: Well-structured dataVolumeTemplates, consider increasing flexibility.The dataVolumeTemplates section is well-defined and provides a good structure for the system disk. The predefined image URLs for different OS options are convenient.
Consider the following improvements for increased flexibility:
Make
volumeModeandaccessModesconfigurable:volumeMode: {{ .Values.systemDisk.volumeMode | default "Block" }} accessModes: {{ .Values.systemDisk.accessModes | default (list "ReadWriteMany") | toYaml | nindent 8 }}Allow custom image URLs:
url: {{ .Values.systemDisk.customImageUrl | default (index .Values.predefinedImages .Values.systemDisk.image) }}Consider using a
switchstatement for image selection to improve readability:{{- $imageUrl := "" }} {{- switch .Values.systemDisk.image }} {{- case "cirros" }} {{- $imageUrl = "https://download.cirros-cloud.net/0.6.2/cirros-0.6.2-x86_64-disk.img" }} {{- case "ubuntu" }} {{- $imageUrl = "https://cloud-images.ubuntu.com/noble/current/noble-server-cloudimg-amd64.img" }} ... {{- end }} url: {{ $imageUrl }}These changes would provide more flexibility while maintaining the current functionality.
54-85: Well-structured template spec, consider enhancing network configuration.The template spec section is well-organized and follows KubeVirt conventions. The flexible resource configuration and appropriate disk setups are commendable.
Consider enhancing the network interface configuration to support multiple interfaces:
interfaces: {{- range $index, $network := .Values.networks }} - name: {{ $network.name | default (printf "net%d" $index) }} {{ $network.type | default "bridge" }}: {} {{- end }}This change would allow users to specify multiple network interfaces with different types in their values file, providing more flexibility for complex networking scenarios.
packages/apps/virtual-machine/README.md (3)
1-10: LGTM! Consider adding a brief mention of Cozystack.The introduction and deployment details provide clear and concise information about the Virtual Machine and its management through KubeVirt. The external links to documentation are helpful for users who want to dive deeper.
Consider adding a brief mention of how this Virtual Machine feature relates to Cozystack, to provide context for users who might be new to the project.
12-33: LGTM! Specify language for code blocks.The instructions for accessing the virtual machine are clear and comprehensive. Users will find this information very helpful.
To improve the formatting and enable syntax highlighting, specify the language for each code block. For example:
-``` +```bash virtctl console <vm>🧰 Tools
🪛 Markdownlint
19-19: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
25-25: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
55-161: LGTM! Consider minor language improvements.The descriptions of the various VM series (U, O, CX, M, and RT) are informative and provide clear explanations of their characteristics and use cases. This information will be valuable for users choosing the appropriate VM type for their needs.
Consider the following minor language improvements:
- Remove commas before "if" in phrases like "permitted to burst beyond this baseline, if excess compute resources are available" (lines 70, 86, 135).
- Replace "in order to" with "to" for conciseness (lines 88, 101, 110, 113, 116, 118, 132, 152, 155, 158).
These changes will improve readability without altering the content's meaning.
🧰 Tools
🪛 LanguageTool
[typographical] ~70-~70: Usually, there’s no comma before “if”.
Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl...(IF_NO_COMMA)
[typographical] ~86-~86: Usually, there’s no comma before “if”.
Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl...(IF_NO_COMMA)
[style] ~88-~88: Consider a shorter alternative to avoid wordiness.
Context: ...tted Memory* - Memory is over-committed in order to achieve a higher workload density. - ...(IN_ORDER_TO_PREMIUM)
[style] ~101-~101: Consider a shorter alternative to avoid wordiness.
Context: ...given to the compute threads of the VM. In order to ensure this, some additional cores (dep...(IN_ORDER_TO_PREMIUM)
[style] ~110-~110: Consider a shorter alternative to avoid wordiness.
Context: ...are: - Hugepages - Hugepages are used in order to improve memory performance. - *Dedica...(IN_ORDER_TO_PREMIUM)
[style] ~113-~113: Consider a shorter alternative to avoid wordiness.
Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante...(IN_ORDER_TO_PREMIUM)
[style] ~116-~116: Consider a shorter alternative to avoid wordiness.
Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the...(IN_ORDER_TO_PREMIUM)
[style] ~118-~118: Consider a shorter alternative to avoid wordiness.
Context: ...NUMA topology is reflected in the guest in order to optimize guest sided cache utilizatio...(IN_ORDER_TO_PREMIUM)
[style] ~132-~132: Consider a shorter alternative to avoid wordiness.
Context: ...are: - Hugepages - Hugepages are used in order to improve memory performance. - *Bursta...(IN_ORDER_TO_PREMIUM)
[typographical] ~135-~135: Usually, there’s no comma before “if”.
Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl...(IF_NO_COMMA)
[style] ~152-~152: Consider a shorter alternative to avoid wordiness.
Context: ...are: - Hugepages - Hugepages are used in order to improve memory performance. - *Dedica...(IN_ORDER_TO_PREMIUM)
[style] ~155-~155: Consider a shorter alternative to avoid wordiness.
Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante...(IN_ORDER_TO_PREMIUM)
[style] ~158-~158: Consider a shorter alternative to avoid wordiness.
Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the...(IN_ORDER_TO_PREMIUM)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
packages/apps/virtual-machine/logos/vm.svgis excluded by!**/*.svg
📒 Files selected for processing (13)
- packages/apps/versions_map (1 hunks)
- packages/apps/virtual-machine/.helmignore (1 hunks)
- packages/apps/virtual-machine/Chart.yaml (1 hunks)
- packages/apps/virtual-machine/Makefile (1 hunks)
- packages/apps/virtual-machine/README.md (1 hunks)
- packages/apps/virtual-machine/hack/update-instance-types.sh (1 hunks)
- packages/apps/virtual-machine/templates/_helpers.tpl (1 hunks)
- packages/apps/virtual-machine/templates/secret.yaml (1 hunks)
- packages/apps/virtual-machine/templates/service.yaml (1 hunks)
- packages/apps/virtual-machine/templates/vm.yaml (1 hunks)
- packages/apps/virtual-machine/values.schema.json (1 hunks)
- packages/apps/virtual-machine/values.yaml (1 hunks)
- packages/extra/versions_map (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (8)
- packages/apps/versions_map
- packages/apps/virtual-machine/.helmignore
- packages/apps/virtual-machine/Chart.yaml
- packages/apps/virtual-machine/Makefile
- packages/apps/virtual-machine/hack/update-instance-types.sh
- packages/apps/virtual-machine/templates/_helpers.tpl
- packages/apps/virtual-machine/values.schema.json
- packages/extra/versions_map
🧰 Additional context used
🪛 LanguageTool
packages/apps/virtual-machine/README.md
[style] ~51-~51: To form a complete sentence, be sure to include a subject or ‘there’.
Context: ... of SSH public keys for authentication. Can be a single key or a list of keys. ...(MISSING_IT_THERE)
[typographical] ~70-~70: Usually, there’s no comma before “if”.
Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl...(IF_NO_COMMA)
[typographical] ~86-~86: Usually, there’s no comma before “if”.
Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl...(IF_NO_COMMA)
[style] ~88-~88: Consider a shorter alternative to avoid wordiness.
Context: ...tted Memory* - Memory is over-committed in order to achieve a higher workload density. - ...(IN_ORDER_TO_PREMIUM)
[style] ~101-~101: Consider a shorter alternative to avoid wordiness.
Context: ...given to the compute threads of the VM. In order to ensure this, some additional cores (dep...(IN_ORDER_TO_PREMIUM)
[style] ~110-~110: Consider a shorter alternative to avoid wordiness.
Context: ...are: - Hugepages - Hugepages are used in order to improve memory performance. - *Dedica...(IN_ORDER_TO_PREMIUM)
[style] ~113-~113: Consider a shorter alternative to avoid wordiness.
Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante...(IN_ORDER_TO_PREMIUM)
[style] ~116-~116: Consider a shorter alternative to avoid wordiness.
Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the...(IN_ORDER_TO_PREMIUM)
[style] ~118-~118: Consider a shorter alternative to avoid wordiness.
Context: ...NUMA topology is reflected in the guest in order to optimize guest sided cache utilizatio...(IN_ORDER_TO_PREMIUM)
[style] ~132-~132: Consider a shorter alternative to avoid wordiness.
Context: ...are: - Hugepages - Hugepages are used in order to improve memory performance. - *Bursta...(IN_ORDER_TO_PREMIUM)
[typographical] ~135-~135: Usually, there’s no comma before “if”.
Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl...(IF_NO_COMMA)
[style] ~152-~152: Consider a shorter alternative to avoid wordiness.
Context: ...are: - Hugepages - Hugepages are used in order to improve memory performance. - *Dedica...(IN_ORDER_TO_PREMIUM)
[style] ~155-~155: Consider a shorter alternative to avoid wordiness.
Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante...(IN_ORDER_TO_PREMIUM)
[style] ~158-~158: Consider a shorter alternative to avoid wordiness.
Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the...(IN_ORDER_TO_PREMIUM)
🪛 Markdownlint
packages/apps/virtual-machine/README.md
19-19: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
25-25: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
52-52: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
53-53: Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
53-53: Expected: 3; Actual: 1; Too few cells, row will be missing data
Table column count(MD056, table-column-count)
🪛 yamllint
packages/apps/virtual-machine/templates/secret.yaml
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
[error] 9-9: trailing spaces
(trailing-spaces)
packages/apps/virtual-machine/templates/service.yaml
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
packages/apps/virtual-machine/templates/vm.yaml
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
packages/apps/virtual-machine/values.yaml
[error] 21-21: trailing spaces
(trailing-spaces)
🔇 Additional comments (9)
packages/apps/virtual-machine/templates/secret.yaml (1)
12-21: LGTM! Cloud Init Secret implementation is well-structured.The Cloud Init Secret is implemented correctly:
- Conditional rendering based on
.Values.cloudInitis appropriate.- The Secret naming follows the established convention.
- Using
stringDatafor the cloud-init userdata is the right approach.- The
nindentfunction ensures proper YAML formatting of the cloud-init data.packages/apps/virtual-machine/templates/service.yaml (2)
1-8: LGTM: Conditional creation and metadata are well-structured.The conditional creation of the Service based on
.Values.externalprovides flexibility. The use of template functions for name and labels promotes consistency across resources.🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
1-21: LGTM: Overall structure is correct, with a note on linting.The file structure and indentation follow Kubernetes and YAML conventions correctly.
Note: The yamllint error on line 1 is a false positive due to the Helm template syntax. To verify this and check for any other potential issues, you can run the following command:
This command will strip out the Helm template syntax before running yamllint, which should resolve the false positive and highlight any real YAML issues if they exist.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
packages/apps/virtual-machine/values.yaml (2)
3-7: LGTM: External access configuration is well-defined and secure.The external access configuration is clear, well-documented, and follows good security practices by disabling external access by default. The option to specify external ports provides flexibility for different use cases.
33-39: LGTM: SSH keys configuration is well-defined and flexible.The SSH keys configuration is clear, well-documented, and provides a good example of usage. Initializing it as an empty array is a sensible default, allowing users to add their own keys as needed.
packages/apps/virtual-machine/templates/vm.yaml (3)
8-25: Well-structured metadata and spec section.The metadata and basic spec section is well-organized and follows Kubernetes resource conventions. The use of template functions for name and labels promotes consistency across resources. The conditional inclusion of
instancetypeandpreferencefields provides flexibility in VM configuration.
86-94: Secure and flexible SSH key configuration.The SSH key configuration section is well-implemented. It conditionally includes SSH public key access credentials, uses a secret for secure storage, and appropriately configures the key propagation method as noCloud.
95-105: Well-structured volumes configuration.The volumes configuration section is well-implemented. It sets a reasonable termination grace period, correctly configures the system disk volume, and conditionally adds a cloud-init disk volume. This approach provides good flexibility for different VM configurations.
packages/apps/virtual-machine/README.md (1)
1-268: Overall, excellent documentation with minor formatting improvements needed.This README file provides comprehensive and valuable information about the Virtual Machine feature. It covers all essential aspects, including an overview, deployment details, access instructions, parameters, and detailed descriptions of various VM series. The content is well-structured and informative.
To further improve this documentation:
- Fix table formatting issues throughout the document by adding leading and trailing pipes to each row and ensuring proper header and separator rows.
- Specify the language for code blocks to enable syntax highlighting.
- Make minor language improvements as suggested in previous comments.
- Verify the existence of the DEVELOPMENT.md file and update accordingly.
- Consider adding a brief mention of how this Virtual Machine feature relates to Cozystack in the introduction.
Once these minor issues are addressed, this README will serve as an excellent resource for users working with the Virtual Machine feature.
🧰 Tools
🪛 LanguageTool
[style] ~51-~51: To form a complete sentence, be sure to include a subject or ‘there’.
Context: ... of SSH public keys for authentication. Can be a single key or a list of keys. ...(MISSING_IT_THERE)
[typographical] ~70-~70: Usually, there’s no comma before “if”.
Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl...(IF_NO_COMMA)
[typographical] ~86-~86: Usually, there’s no comma before “if”.
Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl...(IF_NO_COMMA)
[style] ~88-~88: Consider a shorter alternative to avoid wordiness.
Context: ...tted Memory* - Memory is over-committed in order to achieve a higher workload density. - ...(IN_ORDER_TO_PREMIUM)
[style] ~101-~101: Consider a shorter alternative to avoid wordiness.
Context: ...given to the compute threads of the VM. In order to ensure this, some additional cores (dep...(IN_ORDER_TO_PREMIUM)
[style] ~110-~110: Consider a shorter alternative to avoid wordiness.
Context: ...are: - Hugepages - Hugepages are used in order to improve memory performance. - *Dedica...(IN_ORDER_TO_PREMIUM)
[style] ~113-~113: Consider a shorter alternative to avoid wordiness.
Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante...(IN_ORDER_TO_PREMIUM)
[style] ~116-~116: Consider a shorter alternative to avoid wordiness.
Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the...(IN_ORDER_TO_PREMIUM)
[style] ~118-~118: Consider a shorter alternative to avoid wordiness.
Context: ...NUMA topology is reflected in the guest in order to optimize guest sided cache utilizatio...(IN_ORDER_TO_PREMIUM)
[style] ~132-~132: Consider a shorter alternative to avoid wordiness.
Context: ...are: - Hugepages - Hugepages are used in order to improve memory performance. - *Bursta...(IN_ORDER_TO_PREMIUM)
[typographical] ~135-~135: Usually, there’s no comma before “if”.
Context: ... permitted to burst beyond this baseline, if excess compute resources are availabl...(IF_NO_COMMA)
[style] ~152-~152: Consider a shorter alternative to avoid wordiness.
Context: ...are: - Hugepages - Hugepages are used in order to improve memory performance. - *Dedica...(IN_ORDER_TO_PREMIUM)
[style] ~155-~155: Consider a shorter alternative to avoid wordiness.
Context: ...re exclusively assigned to every vCPU in order to provide fixed and high compute guarante...(IN_ORDER_TO_PREMIUM)
[style] ~158-~158: Consider a shorter alternative to avoid wordiness.
Context: ...r threads are isolated from the vCPUs in order to reduce emaulation related impact on the...(IN_ORDER_TO_PREMIUM)
🪛 Markdownlint
19-19: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
25-25: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
52-52: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
53-53: Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
53-53: Expected: 3; Actual: 1; Too few cells, row will be missing data
Table column count(MD056, table-column-count)
| ## @param resources.cpu The number of CPU cores allocated to the virtual machine | ||
| ## @param resources.memory The amount of memory allocated to the virtual machine | ||
| resources: | ||
| cpu: "" | ||
| memory: "" |
There was a problem hiding this comment.
Improve resource specification to ensure controlled allocation.
The current resource configuration leaves both CPU and memory unspecified, which could lead to uncontrolled resource allocation. This issue was previously identified and the suggestions for improvement are still valid.
Consider the following improvements:
- Provide default values for
cpuandmemoryto ensure controlled resource allocation. - Add comments explaining the format for these values.
- Include a note recommending users to adjust these values based on their specific needs and cluster capabilities.
Example:
resources:
cpu: "500m" # 0.5 CPU cores
memory: "1Gi" # 1 Gibibyte of memory
# Note: Adjust these values based on your specific needs and cluster capabilities| networks: | ||
| - name: default | ||
| pod: {} |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider enhancing network configuration flexibility.
While the current network configuration is simple and suitable for basic use cases, it might be limiting for more complex networking requirements.
Consider modifying the networks section to support multiple interfaces and different network types:
networks:
{{- range $index, $network := .Values.networks }}
- name: {{ $network.name | default (printf "net%d" $index) }}
{{ $network.type | default "pod" }}: {}
{{- end }}This change would allow users to specify multiple network interfaces with different types in their values file, providing more flexibility for various networking scenarios.
| ## Parameters | ||
|
|
||
| ### Common parameters | ||
|
|
||
| | Name | Description | Value | | ||
| | ------------------------- | ---------------------------------------------------------------------------------------------------------- | ---------------- | | ||
| | `external` | Enable external access from outside the cluster | `false` | | ||
| | `externalPorts` | Specify ports to forward from outside the cluster | `[]` | | ||
| | `running` | Determines if the virtual machine should be running | `true` | | ||
| | `instanceType` | Virtual Machine instance type | `u1.medium` | | ||
| | `instanceProfile` | Virtual Machine prefferences profile | `ubuntu` | | ||
| | `systemDisk.image` | The base image for the virtual machine. Allowed values: `ubuntu`, `cirros`, `alpine`, `fedora` and `talos` | `ubuntu` | | ||
| | `systemDisk.storage` | The size of the disk allocated for the virtual machine | `5Gi` | | ||
| | `systemDisk.storageClass` | StorageClass used to store the data | `replicated` | | ||
| | `resources.cpu` | The number of CPU cores allocated to the virtual machine | `""` | | ||
| | `resources.memory` | The amount of memory allocated to the virtual machine | `""` | | ||
| | `sshKeys` | List of SSH public keys for authentication. Can be a single key or a list of keys. | `[]` | | ||
| | `cloudInit` | cloud-init user data config. See cloud-init documentation for more details. | `#cloud-config | ||
| ` | |
There was a problem hiding this comment.
Fix table formatting and adjust cloudInit parameter value.
The parameters table provides valuable information about common configuration options. However, there are some formatting issues that need to be addressed:
- Add leading and trailing pipes to each row of the table.
- Ensure the separator row (line 40) has the correct number of cells.
- Adjust the
cloudInitparameter value to fit on one line or format it differently.
Here's an example of how the corrected table header and separator should look:
| Name | Description | Value |
|------|-------------|-------|Apply this format to the entire table. For the cloudInit parameter, consider using a code block or adjusting the line breaks:
| `cloudInit` | cloud-init user data config. See cloud-init documentation for more details. | `#cloud-config` |or
| `cloudInit` | cloud-init user data config. See cloud-init documentation for more details. | ```yaml
#cloud-config
``` |Choose the format that best fits your needs and maintains readability.
🧰 Tools
🪛 LanguageTool
[style] ~51-~51: To form a complete sentence, be sure to include a subject or ‘there’.
Context: ... of SSH public keys for authentication. Can be a single key or a list of keys. ...(MISSING_IT_THERE)
🪛 Markdownlint
52-52: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
53-53: Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
53-53: Expected: 3; Actual: 1; Too few cells, row will be missing data
Table column count(MD056, table-column-count)
| ## Resources | ||
|
|
||
| The following instancetype resources are provided by Cozystack: | ||
|
|
||
| Name | vCPUs | Memory | ||
| -----|-------|------- | ||
| cx1.2xlarge | 8 | 16Gi | ||
| cx1.4xlarge | 16 | 32Gi | ||
| cx1.8xlarge | 32 | 64Gi | ||
| cx1.large | 2 | 4Gi | ||
| cx1.medium | 1 | 2Gi | ||
| cx1.xlarge | 4 | 8Gi | ||
| gn1.2xlarge | 8 | 32Gi | ||
| gn1.4xlarge | 16 | 64Gi | ||
| gn1.8xlarge | 32 | 128Gi | ||
| gn1.xlarge | 4 | 16Gi | ||
| m1.2xlarge | 8 | 64Gi | ||
| m1.4xlarge | 16 | 128Gi | ||
| m1.8xlarge | 32 | 256Gi | ||
| m1.large | 2 | 16Gi | ||
| m1.xlarge | 4 | 32Gi | ||
| n1.2xlarge | 16 | 32Gi | ||
| n1.4xlarge | 32 | 64Gi | ||
| n1.8xlarge | 64 | 128Gi | ||
| n1.large | 4 | 8Gi | ||
| n1.medium | 4 | 4Gi | ||
| n1.xlarge | 8 | 16Gi | ||
| o1.2xlarge | 8 | 32Gi | ||
| o1.4xlarge | 16 | 64Gi | ||
| o1.8xlarge | 32 | 128Gi | ||
| o1.large | 2 | 8Gi | ||
| o1.medium | 1 | 4Gi | ||
| o1.micro | 1 | 1Gi | ||
| o1.nano | 1 | 512Mi | ||
| o1.small | 1 | 2Gi | ||
| o1.xlarge | 4 | 16Gi | ||
| rt1.2xlarge | 8 | 32Gi | ||
| rt1.4xlarge | 16 | 64Gi | ||
| rt1.8xlarge | 32 | 128Gi | ||
| rt1.large | 2 | 8Gi | ||
| rt1.medium | 1 | 4Gi | ||
| rt1.micro | 1 | 1Gi | ||
| rt1.small | 1 | 2Gi | ||
| rt1.xlarge | 4 | 16Gi | ||
| u1.2xlarge | 8 | 32Gi | ||
| u1.2xmedium | 2 | 4Gi | ||
| u1.4xlarge | 16 | 64Gi | ||
| u1.8xlarge | 32 | 128Gi | ||
| u1.large | 2 | 8Gi | ||
| u1.medium | 1 | 4Gi | ||
| u1.micro | 1 | 1Gi | ||
| u1.nano | 1 | 512Mi | ||
| u1.small | 1 | 2Gi | ||
| u1.xlarge | 4 | 16Gi |
There was a problem hiding this comment.
Fix table formatting for instancetype resources.
The instancetype resources table provides valuable information about the available VM configurations. However, the table formatting needs to be adjusted to ensure proper rendering in Markdown:
- Add leading and trailing pipes to each row of the table.
- Ensure the header row and separator row are correctly formatted.
Here's an example of how the corrected table header and separator should look:
| Name | vCPUs | Memory |
|------|-------|--------|Apply this format to the entire table. This will improve readability and ensure proper rendering across different Markdown viewers.
🧰 Tools
🪛 Markdownlint
172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
172-172: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
173-173: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
174-174: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
175-175: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
176-176: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
177-177: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
178-178: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
179-179: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
180-180: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
181-181: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
182-182: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
183-183: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
184-184: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
185-185: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
186-186: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
187-187: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
188-188: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
189-189: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
190-190: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
191-191: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
192-192: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
193-193: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
194-194: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
195-195: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
196-196: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
197-197: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
198-198: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
199-199: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
200-200: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
201-201: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
202-202: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
203-203: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
204-204: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
205-205: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
206-206: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
207-207: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
208-208: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
209-209: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
210-210: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
211-211: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
212-212: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
213-213: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
214-214: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
215-215: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
216-216: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
217-217: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
218-218: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
219-219: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
220-220: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
221-221: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
| The following preference resources are provided by Cozystack: | ||
|
|
||
| Name | Guest OS | ||
| -----|--------- | ||
| alpine | Alpine | ||
| centos.7 | CentOS 7 | ||
| centos.7.desktop | CentOS 7 | ||
| centos.stream10 | CentOS Stream 10 | ||
| centos.stream10.desktop | CentOS Stream 10 | ||
| centos.stream8 | CentOS Stream 8 | ||
| centos.stream8.desktop | CentOS Stream 8 | ||
| centos.stream8.dpdk | CentOS Stream 8 | ||
| centos.stream9 | CentOS Stream 9 | ||
| centos.stream9.desktop | CentOS Stream 9 | ||
| centos.stream9.dpdk | CentOS Stream 9 | ||
| cirros | Cirros | ||
| fedora | Fedora (amd64) | ||
| fedora.arm64 | Fedora (arm64) | ||
| opensuse.leap | OpenSUSE Leap | ||
| opensuse.tumbleweed | OpenSUSE Tumbleweed | ||
| rhel.10 | Red Hat Enterprise Linux 10 Beta (amd64) | ||
| rhel.10.arm64 | Red Hat Enterprise Linux 10 Beta (arm64) | ||
| rhel.7 | Red Hat Enterprise Linux 7 | ||
| rhel.7.desktop | Red Hat Enterprise Linux 7 | ||
| rhel.8 | Red Hat Enterprise Linux 8 | ||
| rhel.8.desktop | Red Hat Enterprise Linux 8 | ||
| rhel.8.dpdk | Red Hat Enterprise Linux 8 | ||
| rhel.9 | Red Hat Enterprise Linux 9 (amd64) | ||
| rhel.9.arm64 | Red Hat Enterprise Linux 9 (arm64) | ||
| rhel.9.desktop | Red Hat Enterprise Linux 9 Desktop (amd64) | ||
| rhel.9.dpdk | Red Hat Enterprise Linux 9 DPDK (amd64) | ||
| rhel.9.realtime | Red Hat Enterprise Linux 9 Realtime (amd64) | ||
| sles | SUSE Linux Enterprise Server | ||
| ubuntu | Ubuntu | ||
| windows.10 | Microsoft Windows 10 | ||
| windows.10.virtio | Microsoft Windows 10 (virtio) | ||
| windows.11 | Microsoft Windows 11 | ||
| windows.11.virtio | Microsoft Windows 11 (virtio) | ||
| windows.2k16 | Microsoft Windows Server 2016 | ||
| windows.2k16.virtio | Microsoft Windows Server 2016 (virtio) | ||
| windows.2k19 | Microsoft Windows Server 2019 | ||
| windows.2k19.virtio | Microsoft Windows Server 2019 (virtio) | ||
| windows.2k22 | Microsoft Windows Server 2022 | ||
| windows.2k22.virtio | Microsoft Windows Server 2022 (virtio) | ||
| windows.2k25 | Microsoft Windows Server 2025 | ||
| windows.2k25.virtio | Microsoft Windows Server 2025 (virtio) |
There was a problem hiding this comment.
Fix table formatting for preference resources.
The preference resources table provides valuable information about the supported guest operating systems. However, the table formatting needs to be adjusted to ensure proper rendering in Markdown:
- Add leading and trailing pipes to each row of the table.
- Ensure the header row and separator row are correctly formatted.
Here's an example of how the corrected table header and separator should look:
| Name | Guest OS |
|------|----------|Apply this format to the entire table. This will improve readability and ensure proper rendering across different Markdown viewers.
🧰 Tools
🪛 Markdownlint
225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
225-225: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
226-226: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
227-227: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
228-228: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
229-229: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
230-230: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
231-231: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
232-232: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
233-233: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
234-234: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
235-235: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
236-236: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
237-237: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
238-238: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
239-239: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
240-240: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
241-241: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
242-242: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
243-243: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
244-244: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
245-245: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
246-246: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
247-247: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
248-248: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
249-249: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
250-250: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
251-251: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
252-252: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
253-253: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
254-254: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
255-255: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
256-256: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
257-257: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
258-258: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
259-259: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
260-260: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
261-261: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
262-262: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
263-263: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
264-264: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
265-265: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
266-266: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
267-267: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing leading pipe
Table pipe style(MD055, table-pipe-style)
268-268: Expected: leading_and_trailing; Actual: no_leading_or_trailing; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
| ## Development | ||
|
|
||
| To get started with customizing or creating your own instancetypes and preferences | ||
| see [DEVELOPMENT.md](./DEVELOPMENT.md). |
There was a problem hiding this comment.
💡 Codebase verification
Update the DEVELOPMENT.md reference or create the file.
The Development section refers to a non-existent DEVELOPMENT.md file. Please either:
- Create the DEVELOPMENT.md file with the necessary information for customizing instancetypes and preferences.
- Update the reference in README.md to point to the correct location of the development documentation.
This will ensure that users can find the information they need for customization.
🔗 Analysis chain
Verify the existence of DEVELOPMENT.md file.
The Development section provides a helpful reference for customizing instancetypes and preferences. However, we need to ensure that the referenced DEVELOPMENT.md file exists in the repository.
If the DEVELOPMENT.md file doesn't exist, please take one of the following actions:
- Create the DEVELOPMENT.md file with the necessary information for customizing instancetypes and preferences.
- Update the reference in README.md to point to the correct location of the development documentation.
This will ensure that users can find the information they need for customization.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if DEVELOPMENT.md exists in the same directory as README.md
if [ -f "$(dirname "$0")/DEVELOPMENT.md" ]; then
echo "DEVELOPMENT.md file exists."
else
echo "DEVELOPMENT.md file not found. Please create this file or update the reference in README.md."
fi
Length of output: 274
Revert removing Virtual Machine, removed by #403
Summary by CodeRabbit
New Features
virtual-machinewith multiple version entries.virtual-machineapplication.Bug Fixes