Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be more defensive about model type check #17

Closed
wants to merge 7 commits into from

Conversation

jonasi
Copy link
Contributor

@jonasi jonasi commented Mar 20, 2024

No description provided.

elif hasattr(llm, 'model'):
return llm.model
else:
return '???'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol

@aelaguiz
Copy link
Owner

This needs to be rebased and the tests need to be fixed

@jonasi
Copy link
Contributor Author

jonasi commented Mar 21, 2024

will open a new pr will all the changes

@jonasi jonasi closed this Mar 21, 2024
@jonasi jonasi deleted the isao/fix-model-type-check branch March 21, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants