quick fix for considering singleFieldDelimeter when input tags #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… button (which used for letter in cyrillic languages)
This was referenced Jan 15, 2014
|
It would be better to change line 244 as follows: (String.fromCharCode(event.which) === that.options.singleFieldDelimiter && event.shiftKey === false) || Edit - this might only work with a keypress event instead of a keydown event... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using $.ui.keyCode.COMMA for end of tag is not good idea, because this scan code corresponds to letter in other languages (letter
бin cyrillic) what prevent entering tags with this letter. It would be better to use singleFieldDelimiter as end of tag.