Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang/localization of "year in review" #3262

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

Vito0912
Copy link
Contributor

@Vito0912 Vito0912 commented Aug 9, 2024

This PR adds localization for the shareable image on the Stats page (also known as "YEAR IN REVIEW").

It's important to note that since this is an image/canvas and the text is "drawn" onto it, the length of the text is not truly flexible, as the boxes/containers do not adjust accordingly.

I suggest adding a note in Weblate to inform translators that this string should not be too long and setting a "soft limit" to proactively warn when a certain character limit is exceeded. Of course, some characters are longer or shorter, but this would serve as a guideline.

closes #3260

@advplyr
Copy link
Owner

advplyr commented Aug 9, 2024

These need to pass in a max length so the text is truncated and doesn't overflow. If a string is added that is too long it should not overflow the card.

@Vito0912
Copy link
Contributor Author

Vito0912 commented Aug 9, 2024

These need to pass in a max length so the text is truncated and doesn't overflow. If a string is added that is too long it should not overflow the card.

Got it. Is the width reffering to pixels or what metric?

Also, is there a command to sort the strings alphabetically?

@Vito0912
Copy link
Contributor Author

Vito0912 commented Aug 9, 2024

See images for reference
1
2
3

@Vito0912
Copy link
Contributor Author

Vito0912 commented Aug 9, 2024

A big thanks to @Heisenberg9469 for sharing the additional pages that are not shown to me, due to lacking listening in 2023, so I could check the dimensions! :)

@advplyr
Copy link
Owner

advplyr commented Aug 9, 2024

Thanks!

@advplyr advplyr merged commit c5ba40a into advplyr:master Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Multi-Language Support for Yearly Overview Images in Statistics Section
2 participants