Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Podcasts pulling (track) artist as author over album artist #3315

Closed
HazardousBackup opened this issue Aug 20, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@HazardousBackup
Copy link

What happened?

When adding podcasts manually ABS pulls from the metadata in the files which works for getting a lot of the information properly filled in if there isn't a matching entry from a metadata site.

However, I've noticed that ABS will pull the track artist as the author (I believe from the first file) even when there is a filled-out album author tag. This seems inappropriate/a mistake.

What did you expect to happen?

If files are added and only the track artist tag is filled out then pulling that as the author makes sense.
For tagging some things, however, it works best for the album artist tag to be the overarching host/author/artist for the program and track artist to be who is the main host/author/artist for that specific episode.

For example, if I added an old radio show, then the album artist might be the author of the overarching program and the track artist might be the main actor.

Steps to reproduce the issue

  1. Create an audio file with tagging information for both artist and album artist
  2. Add the file to ABS in new folder
  3. Manually scan or allow automatic scan to add the new program
  4. See that the track artist will get authorship over the album artist

Audiobookshelf version

v2.12.3

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Firefox

Logs

No response

Additional Notes

I could see a range of options being added here on a per-podcast basis that would allow for some much nicer navigation and tagging.

For example, a more traditional podcast might be a main group of people with rotating guests. In this case, the album artist would make sense to be the main group with the track artist as the guest. This would allow the option for searching podcasts by guest.
This would also work well for anthology style programs where the main host could be the album artist and the writer of that particular episode could be the track artist.

Bringing in Performer and Composer tags would also be useful for similar reasons. Giving some mapping options or setting a standard to follow for tagging would allow for pulling in a lot more info for custom series.

Off Topic:
ABS seems to do a great job already using embedded metadata.
Album art -> Cover Art
Disc Number -> Season
Track Number -> Episode
Comments -> Description
So you have my complements for some good and sane defaults that really help when bringing in something where there isn't likely metadata online.

@HazardousBackup HazardousBackup added the bug Something isn't working label Aug 20, 2024
@HazardousBackup
Copy link
Author

HazardousBackup commented Aug 20, 2024

I double checked trying a radio show under the audiobook category and it gains a lot of metadata but doesn't really work structurally since they aren't really "chapters" but fit the episodic structure of podcasts more.

However, it does add some nice features like publisher, and narrators. Those I think mirror some of the ideas of how to expand podcast metadata.

(Might need to expand this into a separate feature request)

advplyr added a commit that referenced this issue Aug 20, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Aug 20, 2024
Copy link

Fixed in v2.13.0.

@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants