Restore ImageRepoBadHwIdUptane and fix other HWID tests. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pattivacek
commented
Jul 17, 2019
pattivacek
commented
- Image repo Target metadata now has an array of hardwareIDs instead of just one, which matches what tufrepo has been doing for over a year now.
- ImageRepoBadHwIdUptane has been restored but now checks the general custom hardware IDs (instead of ECU-specific HWIDs, which didn't make sense for the image repo).
- BadHwIdUptane has been fixed to also check the general custom hardware IDs (again because the image repo never had or needed ECU-specific HWIDs).
- Also updated some errors to match latest libaktualizr.
* Image repo Target metadata now has an array of hardwareIDs instead of just one, which matches what tufrepo has been doing for over a year now. * ImageRepoBadHwIdUptane has been restored but now checks the general custom hardware IDs (instead of ECU-specific HWIDs, which didn't make sense for the image repo). * BadHwIdUptane has been fixed to also check the general custom hardware IDs (again because the image repo never had or needed ECU-specific HWIDs). * Also updated some errors to match latest libaktualizr. Signed-off-by: Patrick Vacek <[email protected]>
lbonn
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.