Add oe-selftest for aktualizr ptest run on qemu #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Annoyingly, a test using |
|
Softlink it manually in the oe-selftest code before calling ptest? |
|
Looks fine, but in my case I see a few more errors: The first you already know: The second:
|
Signed-off-by: Laurent Bonnans <[email protected]>
lshw is installed in `/usr/sbin` which does not appear when a command is launched outside a non-login shell. Signed-off-by: Laurent Bonnans <[email protected]>
Signed-off-by: Laurent Bonnans <[email protected]>
Signed-off-by: Laurent Bonnans <[email protected]>
lbonn
force-pushed
the
test/oe-selftest-ptest
branch
from
2f69ed3 to
f501bb9
Compare
|
I think your second problem comes from not being able to run lshw as well. I've pushed a fix. I now have: |
|
Oh and the problem with fetcher is more than a memory leak I think: |
The trick to add it in do_compile from cmake.bbclass does not work with do_compile_ptest_base Signed-off-by: Laurent Bonnans <[email protected]>
|
Fixes in advancedtelematic/aktualizr#1173 and advancedtelematic/aktualizr#1174. The valgrind leak however remains, I'd suggest that we'd still merge this soon if possible. |
I don't want to merge if it still breaks, but I'd also like to get it in soon. Can we skip that test for now or do something quick and dirty until we fix it for real? |
|
I thought about merging it now since it doesn't run with the other oe-selftests, as it is in its own .py file. Quick solution would be to run with |
|
Ok I think the leak was introduced here: ostreedev/ostree@21ebc7d, which adds a new |
|
Oh my bad that's a completely different leak, only in master! It looks like the one mentioned earlier has been fixed there actually. |
|
At this point everything looks fine except for fetcher_test: Is that what you see as well? |
|
Yes it's a very frustrating one, as I get it on yocto and my Debian system but not on the docker CI, even when trying the same ostree versions. |
|
On ostree master (89c00e7eb72ddc5aaee3469f281fb5560ff7bd5d), with debug symbols: It could come from some version of glib... |
|
This should help: advancedtelematic/aktualizr#1179 |
Indeed. It passes when I build with that branch. If only that branch succeeded on Travis... |
|
Travis finally passed :) |
Great! If you bump aktualizr's version here, I'll approve and we can merge this. Finally! |
Signed-off-by: Laurent Bonnans <[email protected]>
pattivacek
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still has some failures at the moment, also the full output is often cropped for some unknown reason (the summary of which tests are passing and which aren't still appears in full)