-
Notifications
You must be signed in to change notification settings - Fork 61
ref: moving all configs definition into a single file #1707
Conversation
Is this just the config changes from #1688 pulled out into a separate PR? Or which one should we focus on and review/merge first? |
#include "logging/logging_config.h" | ||
#include "package_manager/packagemanagerconfig.h" | ||
#include "storage/storage_config.h" | ||
#include "libaktualizr/config.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is slightly unfortunate that we have to include a bunch more stuff in aktualizr-secondary that we won't actually use, but for now that seems like a small issue that we can address at another time.
CI only failed because of an issue that Eugene has fixed. Can you rebase? |
Signed-off-by: Kostiantyn Bushko <[email protected]>
Signed-off-by: Kostiantyn Bushko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
==========================================
- Coverage 73.24% 72.47% -0.78%
==========================================
Files 195 188 -7
Lines 14055 14226 +171
==========================================
+ Hits 10295 10310 +15
- Misses 3760 3916 +156
Continue to review full report at Codecov.
|
this is just refactoring of configs, lets focus on this PR first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Kostiantyn Bushko [email protected]