Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

dockerapp: Handle warnings from Compose gracefully #1664

Merged

Conversation

doanac
Copy link
Collaborator

@doanac doanac commented May 4, 2020

Grabbing the docker-app render STDOUT isn't safe. If that file has
docker-compose warnings, they'll be included and then produce invalid
YAML. We should write the YAML directly to disk if we are going to
persist.

Signed-off-by: Andy Doan [email protected]

Grabbing the docker-app render STDOUT isn't safe. If that file has
docker-compose *warnings*, they'll be included and then produce invalid
YAML. We should write the YAML directly to disk if we are going to
persist.

Signed-off-by: Andy Doan <[email protected]>
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pattivacek pattivacek merged commit f6fcc8c into advancedtelematic:master May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants