This repository has been archived by the owner on May 21, 2024. It is now read-only.
Two small exception-related fixes #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbonn
force-pushed
the
fix/exceptions-mini
branch
from
6c95067 to
323ef5d
Compare
There is usually no recovery path Signed-off-by: Laurent Bonnans <[email protected]>
Usually, we want to re-throw what we caught in this case Signed-off-by: Laurent Bonnans <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
==========================================
+ Coverage 82.49% 82.73% +0.24%
==========================================
Files 191 191
Lines 12082 12045 -37
==========================================
- Hits 9967 9966 -1
+ Misses 2115 2079 -36
Continue to review full report at Codecov.
|
pattivacek
approved these changes
Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.