Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Add a SQL busy handler with 2 seconds timeout #1648

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Conversation

lbonn
Copy link
Contributor

@lbonn lbonn commented Apr 17, 2020

We've talked about it but it got forgotten somehow.
It's maybe not required for our current use but I figured it should not hurt.

Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it can't hurt. Am I reading the docs right that the default is just to fail immediately if you don't set this?

@codecov-io
Copy link

Codecov Report

Merging #1648 into master will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   82.72%   82.61%   -0.11%     
==========================================
  Files         191      191              
  Lines       12061    12062       +1     
==========================================
- Hits         9977     9965      -12     
- Misses       2084     2097      +13     
Impacted Files Coverage Δ
src/libaktualizr/storage/sql_utils.h 86.07% <100.00%> (+0.17%) ⬆️
src/libaktualizr/package_manager/ostreemanager.cc 79.04% <0.00%> (-1.48%) ⬇️
src/libaktualizr/storage/sqlstorage.cc 77.40% <0.00%> (-0.94%) ⬇️
src/aktualizr_primary/secondary.cc 86.95% <0.00%> (-0.87%) ⬇️
src/libaktualizr/storage/sqlstorage_base.cc 81.20% <0.00%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d411d...448fa82. Read the comment docs.

@pattivacek pattivacek merged commit 5894a06 into master Apr 17, 2020
@pattivacek pattivacek deleted the fix/sqlite-timeout branch April 17, 2020 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants