This repository has been archived by the owner on May 21, 2024. It is now read-only.
Feat/ota 4118/director targets sanity #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattivacek
requested review from
zabbal,
lbonn,
eu-siemann,
mike-sul,
xcheng-here and
kbushgit
pattivacek
force-pushed
the
feat/OTA-4118/director-targets-sanity
branch
from
e683b13 to
eada9bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1600 +/- ##
=========================================
+ Coverage 82.44% 82.5% +0.05%
=========================================
Files 189 189
Lines 11940 11962 +22
=========================================
+ Hits 9844 9869 +25
+ Misses 2096 2093 -3
Continue to review full report at Codecov.
|
pattivacek
force-pushed
the
feat/OTA-4118/director-targets-sanity
branch
from
eada9bb to
6c91134
Compare
pattivacek
force-pushed
the
feat/OTA-4118/director-targets-sanity
branch
2 times, most recently
from
0210180 to
6f5f09b
Compare
lbonn
reviewed
Mar 16, 2020
* Check that Director Targets metadata doesn't have delegations. * Check that no ECU IDs are repeated in Director Targets metadata. Signed-off-by: Patrick Vacek <[email protected]>
Set last_exception and mark the functions as private. Also move last_exception to UptaneRepository, since it is used in the same way by both repos. Signed-off-by: Patrick Vacek <[email protected]>
The Uptane standard dictates that we should abort if they are found. Signed-off-by: Patrick Vacek <[email protected]>
Co-Authored-By: Laurent Bonnans <[email protected]> Signed-off-by: Patrick Vacek <[email protected]>
We've supported this for a very long time. I put a comment quoting the Uptane standard at the place where the check is done. Signed-off-by: Patrick Vacek <[email protected]>
Signed-off-by: Patrick Vacek <[email protected]>
pattivacek
force-pushed
the
feat/OTA-4118/director-targets-sanity
branch
from
405ebdc to
f6d0d02
Compare
lbonn
approved these changes
Mar 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on advancedtelematic/tuf-test-vectors#69.