This repository has been archived by the owner on May 21, 2024. It is now read-only.
Fix/bad metadata handling #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattivacek
force-pushed
the
fix/bad-metadata-handling
branch
from
d54f0d7 to
bf5666b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
========================================
+ Coverage 80.7% 80.8% +0.1%
========================================
Files 184 184
Lines 11156 11182 +26
========================================
+ Hits 9003 9036 +33
+ Misses 2153 2146 -7
Continue to review full report at Codecov.
|
lbonn
previously approved these changes
Jan 9, 2020
|
Just realized there's a small change I'd like to make to the test I wrote. (No point verifying nothing was installed if we never install anything.) |
Previously these statuses were not necessarily obvious unless you ran with loglevel 0. This just expands the existing log messages with some additional information. Signed-off-by: Patrick Vacek <[email protected]>
We weren't informing the server in this particular case. Signed-off-by: Patrick Vacek <[email protected]>
Previously, checkUpdates() returned any targets that were successfully matched before one that did not. That was inconsistent, it conflicted with the Uptane standard, and it caused an unnecessary download call in UptaneCycle(), which correctly rejected all targets. Also inform the backend of the installation failure in this case, although the installation wasn't even attempted. Signed-off-by: Patrick Vacek <[email protected]>
Signed-off-by: Patrick Vacek <[email protected]>
This way we can report the update failure immediately to the backend. Note this only applies to UptaneCycle(); API users can still control when manifests are sent in this case. Signed-off-by: Patrick Vacek <[email protected]>
Covers that we correctly reject the target and then can continue to get new updates. Also checks that no updates are reported if any one update is invalid. Signed-off-by: Patrick Vacek <[email protected]>
pattivacek
force-pushed
the
fix/bad-metadata-handling
branch
from
bf5666b to
ea2b787
Compare
lbonn
approved these changes
Jan 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug I recently reported and that I believe @kbushgit may have also encountered.