OLPSUP-8795: Import the initial hash from file for IP Secondary

[mike-sul]

Signed-off-by: Mykhaylo Sul [email protected]

[lbonn]

Nice. Do you think adding a non-regression test would be possible here?

[mike-sul]

Nice. Do you think adding a non-regression test would be possible here?

Everything is possible :). The question is if it is reasonable. I am just not sure if the current approach to setting of the initial version is the right one. If not, then we have to rework it, so adding test to something that we are going to throw away does not make sense, otherwise I can add some test. Let's discuss it tomorrow during the meeting.

Please update the changelog, otherwise looks good!

[pattivacek]

To summarize discussion: testing is of course a great idea, but since we think we want to redo this logic really soon anyway, perhaps a test for this quick-fix logic is not such a great use of our time.

[codecov-io]

Codecov Report

Merging #1485 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1485      +/-   ##
==========================================
+ Coverage   80.66%   80.79%   +0.12%     
==========================================
  Files         184      184              
  Lines       11138    11141       +3     
==========================================
+ Hits         8985     9001      +16     
+ Misses       2153     2140      -13

Impacted Files	Coverage Δ
...c/aktualizr_secondary/aktualizr_secondary_config.h	100% <ø> (ø)	⬆️
src/libaktualizr/storage/invstorage.h	97.56% <ø> (ø)	⬆️
.../aktualizr_secondary/aktualizr_secondary_config.cc	94.8% <100%> (+0.13%)	⬆️
.../aktualizr_secondary/aktualizr_secondary_common.cc	88.57% <100%> (+0.33%)	⬆️
src/libaktualizr/primary/initializer.cc	80.64% <0%> (-1.3%)	⬇️
src/aktualizr_primary/main.cc	80.37% <0%> (-0.94%)	⬇️
src/libaktualizr/primary/sotauptaneclient.cc	88.71% <0%> (-0.15%)	⬇️
src/libaktualizr/storage/sqlstorage.cc	77.45% <0%> (+0.66%)	⬆️
src/libaktualizr/storage/sqlstorage_base.cc	79.72% <0%> (+5.4%)	⬆️
src/libaktualizr/storage/sqlstorage_base.h	100% <0%> (+40%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a68cd5...4cef29e. Read the comment docs.

[mike-sul]

@lbonn @patrickvacek please, check out if I updated the changelog correctly.

[pattivacek]

Perfect, thanks!