Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

sotauptaneclient: Make reportHwInfo smarter #1434

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

doanac
Copy link
Collaborator

@doanac doanac commented Nov 4, 2019

Make the reportHwInfo call be like reportNetworkInfo and only send
things when they've changed.

Signed-off-by: Andy Doan [email protected]

Make the reportHwInfo call be like reportNetworkInfo and only send
things when they've changed.

Signed-off-by: Andy Doan <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #1434 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   80.46%   80.56%   +0.09%     
==========================================
  Files         183      183              
  Lines       10911    10913       +2     
==========================================
+ Hits         8780     8792      +12     
+ Misses       2131     2121      -10
Impacted Files Coverage Δ
src/libaktualizr/primary/sotauptaneclient.h 100% <ø> (ø) ⬆️
src/libaktualizr/primary/sotauptaneclient.cc 89.13% <100%> (+0.03%) ⬆️
src/libaktualizr/storage/sqlstorage.cc 76.89% <0%> (ø) ⬆️
src/libaktualizr/storage/sqlstorage_base.cc 81.08% <0%> (+2.02%) ⬆️
src/libaktualizr/package_manager/ostreemanager.cc 80.22% <0%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e3835...cd65a41. Read the comment docs.

Copy link
Contributor

@lbonn lbonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@lbonn lbonn merged commit 13e8652 into advancedtelematic:master Nov 5, 2019
@pattivacek
Copy link
Collaborator

Nice, thanks! I was just recently talking about doing this; didn't realize it'd be so easy.

@mike-sul
Copy link
Collaborator

mike-sul commented Nov 5, 2019

The report will be resend after aktualizr or a device restart .

@doanac doanac deleted the reportHwInfo branch November 5, 2019 15:39
@pattivacek
Copy link
Collaborator

The report will be resend after aktualizr or a device restart .

Yep, I think that's just fine for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants